-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily skip lpmode test for some transceivers with known issue #16547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yejianquan
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
…onic-net#16547) Description of PR Summary: Some sfp transceivers have known issues with lpmode test, where it fails to set_lpmode successfully. After discussion, we need a firmware from optics vendor to fix this issue. Therefore, we will temporarily skip this set_lpmode test for known manufacturer and 400G combination until fix is available. Approach What is the motivation for this PR? Temporarily skip known test failure How did you do it? check conditions to skip the test How did you verify/test it? platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-lc4] 03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 0 (not applicable for this transceiver type) 03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 1 (not applicable for this transceiver type) 03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 2 (not applicable for this transceiver type) 03:30:50 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 3 (not applicable for this transceiver type) 03:30:50 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 4 (not applicable for this transceiver type) 03:30:51 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 5 (not applicable for this transceiver type) 03:30:51 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 6 (not applicable for this transceiver type) 03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 7 (not applicable for this transceiver type) 03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 8 (not applicable for this transceiver type) 03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 9 (not applicable for this transceiver type) 03:30:53 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 10 (not applicable for this transceiver type) 03:30:53 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 11 (not applicable for this transceiver type) 03:30:54 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 12 (not applicable for this transceiver type) 03:30:54 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 13 (not applicable for this transceiver type) 03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 14 (not applicable for this transceiver type) 03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 15 (not applicable for this transceiver type) 03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 16 (not applicable for this transceiver type) 03:30:56 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 17 (not applicable for this transceiver type) 03:30:56 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 18 (not applicable for this transceiver type) 03:30:57 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 19 (not applicable for this transceiver type) 03:30:57 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 20 (not applicable for this transceiver type) 03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 21 (not applicable for this transceiver type) 03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 22 (not applicable for this transceiver type) 03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 23 (not applicable for this transceiver type) 03:30:59 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 24 (not applicable for this transceiver type) 03:30:59 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 25 (not applicable for this transceiver type) 03:31:00 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 26 (not applicable for this transceiver type) 03:31:00 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 27 (not applicable for this transceiver type) 03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 28 (not applicable for this transceiver type) 03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 29 (not applicable for this transceiver type) 03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 30 (not applicable for this transceiver type) 03:31:02 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 31 (not applicable for this transceiver type) PASSED [ 33%] platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-lc2] PASSED [ 66%] platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-sup] SKIPPED (skipping for supervisor node) co-authorized by: [email protected]
Cherry-pick PR to 202411: #16569 |
Merged
11 tasks
yejianquan
pushed a commit
to yejianquan/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
…onic-net#16547) Description of PR Summary: Some sfp transceivers have known issues with lpmode test, where it fails to set_lpmode successfully. After discussion, we need a firmware from optics vendor to fix this issue. Therefore, we will temporarily skip this set_lpmode test for known manufacturer and 400G combination until fix is available. Approach What is the motivation for this PR? Temporarily skip known test failure How did you do it? check conditions to skip the test How did you verify/test it? platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-lc4] 03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 0 (not applicable for this transceiver type) 03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 1 (not applicable for this transceiver type) 03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 2 (not applicable for this transceiver type) 03:30:50 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 3 (not applicable for this transceiver type) 03:30:50 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 4 (not applicable for this transceiver type) 03:30:51 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 5 (not applicable for this transceiver type) 03:30:51 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 6 (not applicable for this transceiver type) 03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 7 (not applicable for this transceiver type) 03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 8 (not applicable for this transceiver type) 03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 9 (not applicable for this transceiver type) 03:30:53 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 10 (not applicable for this transceiver type) 03:30:53 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 11 (not applicable for this transceiver type) 03:30:54 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 12 (not applicable for this transceiver type) 03:30:54 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 13 (not applicable for this transceiver type) 03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 14 (not applicable for this transceiver type) 03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 15 (not applicable for this transceiver type) 03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 16 (not applicable for this transceiver type) 03:30:56 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 17 (not applicable for this transceiver type) 03:30:56 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 18 (not applicable for this transceiver type) 03:30:57 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 19 (not applicable for this transceiver type) 03:30:57 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 20 (not applicable for this transceiver type) 03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 21 (not applicable for this transceiver type) 03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 22 (not applicable for this transceiver type) 03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 23 (not applicable for this transceiver type) 03:30:59 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 24 (not applicable for this transceiver type) 03:30:59 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 25 (not applicable for this transceiver type) 03:31:00 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 26 (not applicable for this transceiver type) 03:31:00 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 27 (not applicable for this transceiver type) 03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 28 (not applicable for this transceiver type) 03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 29 (not applicable for this transceiver type) 03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 30 (not applicable for this transceiver type) 03:31:02 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 31 (not applicable for this transceiver type) PASSED [ 33%] platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-lc2] PASSED [ 66%] platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-sup] SKIPPED (skipping for supervisor node) co-authorized by: [email protected]
mssonicbld
pushed a commit
that referenced
this pull request
Jan 18, 2025
…16547) Description of PR Summary: Some sfp transceivers have known issues with lpmode test, where it fails to set_lpmode successfully. After discussion, we need a firmware from optics vendor to fix this issue. Therefore, we will temporarily skip this set_lpmode test for known manufacturer and 400G combination until fix is available. Approach What is the motivation for this PR? Temporarily skip known test failure How did you do it? check conditions to skip the test How did you verify/test it? platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-lc4] 03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 0 (not applicable for this transceiver type) 03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 1 (not applicable for this transceiver type) 03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 2 (not applicable for this transceiver type) 03:30:50 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 3 (not applicable for this transceiver type) 03:30:50 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 4 (not applicable for this transceiver type) 03:30:51 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 5 (not applicable for this transceiver type) 03:30:51 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 6 (not applicable for this transceiver type) 03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 7 (not applicable for this transceiver type) 03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 8 (not applicable for this transceiver type) 03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 9 (not applicable for this transceiver type) 03:30:53 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 10 (not applicable for this transceiver type) 03:30:53 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 11 (not applicable for this transceiver type) 03:30:54 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 12 (not applicable for this transceiver type) 03:30:54 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 13 (not applicable for this transceiver type) 03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 14 (not applicable for this transceiver type) 03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 15 (not applicable for this transceiver type) 03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 16 (not applicable for this transceiver type) 03:30:56 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 17 (not applicable for this transceiver type) 03:30:56 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 18 (not applicable for this transceiver type) 03:30:57 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 19 (not applicable for this transceiver type) 03:30:57 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 20 (not applicable for this transceiver type) 03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 21 (not applicable for this transceiver type) 03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 22 (not applicable for this transceiver type) 03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 23 (not applicable for this transceiver type) 03:30:59 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 24 (not applicable for this transceiver type) 03:30:59 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 25 (not applicable for this transceiver type) 03:31:00 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 26 (not applicable for this transceiver type) 03:31:00 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 27 (not applicable for this transceiver type) 03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 28 (not applicable for this transceiver type) 03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 29 (not applicable for this transceiver type) 03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 30 (not applicable for this transceiver type) 03:31:02 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 31 (not applicable for this transceiver type) PASSED [ 33%] platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-lc2] PASSED [ 66%] platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-sup] SKIPPED (skipping for supervisor node) co-authorized by: [email protected]
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Some sfp transceivers have known issues with lpmode test, where it fails to set_lpmode successfully. After discussion, we need a firmware from optics vendor to fix this issue.
Therefore, we will temporarily skip this set_lpmode test for known manufacturer and 400G combination until fix is available.
Type of change
Back port request
Approach
What is the motivation for this PR?
Temporarily skip known test failure
How did you do it?
check conditions to skip the test
How did you verify/test it?
platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-lc4]
03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 0 (not applicable for this transceiver type)
03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 1 (not applicable for this transceiver type)
03:30:49 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 2 (not applicable for this transceiver type)
03:30:50 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 3 (not applicable for this transceiver type)
03:30:50 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 4 (not applicable for this transceiver type)
03:30:51 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 5 (not applicable for this transceiver type)
03:30:51 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 6 (not applicable for this transceiver type)
03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 7 (not applicable for this transceiver type)
03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 8 (not applicable for this transceiver type)
03:30:52 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 9 (not applicable for this transceiver type)
03:30:53 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 10 (not applicable for this transceiver type)
03:30:53 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 11 (not applicable for this transceiver type)
03:30:54 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 12 (not applicable for this transceiver type)
03:30:54 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 13 (not applicable for this transceiver type)
03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 14 (not applicable for this transceiver type)
03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 15 (not applicable for this transceiver type)
03:30:55 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 16 (not applicable for this transceiver type)
03:30:56 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 17 (not applicable for this transceiver type)
03:30:56 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 18 (not applicable for this transceiver type)
03:30:57 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 19 (not applicable for this transceiver type)
03:30:57 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 20 (not applicable for this transceiver type)
03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 21 (not applicable for this transceiver type)
03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 22 (not applicable for this transceiver type)
03:30:58 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 23 (not applicable for this transceiver type)
03:30:59 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 24 (not applicable for this transceiver type)
03:30:59 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 25 (not applicable for this transceiver type)
03:31:00 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 26 (not applicable for this transceiver type)
03:31:00 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 27 (not applicable for this transceiver type)
03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 28 (not applicable for this transceiver type)
03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 29 (not applicable for this transceiver type)
03:31:01 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 30 (not applicable for this transceiver type)
03:31:02 test_sfp.test_lpmode L0795 WARNING| test_lpmode: Skipping transceiver 31 (not applicable for this transceiver type)
PASSED [ 33%]
platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-lc2] PASSED [ 66%]
platform_tests/api/test_sfp.py::TestSfpApi::test_lpmode[xxx-sup] SKIPPED (skipping for supervisor node)
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation