Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:16535] Fix ASIC check in test_pfcwd_function #16540

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
The issue was introduced by PR #15772
The ASIC check is not working as expected because of the syntax error in the code. It should be in instead of ==

if dut.facts['asic_type'] == ["mellanox", "cisco-8000"]:

The issue will cause PFCWD function not stable on some platform.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

This PR is to fix a syntax issue in test_pfcwd_function.py.

How did you do it?

Fix the syntax.

How did you verify/test it?

The change is verified on a physical testbed.

collected 1 item 

pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_actions[bjw2-can-4600c-2] ^H ^HPASSED [100%]

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Not a new test.

Documentation

@mssonicbld
Copy link
Collaborator Author

/azp run

@mssonicbld
Copy link
Collaborator Author

Original PR: #16535

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 470bf4a into sonic-net:202411 Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants