-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support smartswitch in get_testbed_type and announce_routes #16536
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@bingwang-ms PR conflicts with 202405 branch |
…t#16536) * Support smartswitch in get_testbed_type
Cherry-pick PR to 202411: #16561 |
* Support smartswitch in get_testbed_type
Description of PR
Summary:
This PR is to support
smartswitch
inget_testbed_type
.Before this change, the WARNING message shows up in each run.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to support
smartswitch
inget_testbed_type
.How did you do it?
Update the regex in
get_testbed_type
to include `smartswitch.How did you verify/test it?
Verified by manually run a test. The warning message doesn't show up any more.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Not a new test.
Documentation