Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check command to debug PTF unreachable issue #16444

Merged

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Jan 10, 2025

Add sanity check command to debug PTF unreachable issue.

Why I did it

TACACS test case failed because PTF device unreachable, need more info to debug.

Work item tracking
  • Microsoft ADO: 30626367

How I did it

Add sanity check command to debug PTF unreachable issue.

How to verify it

Pass all test case.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Add sanity check command to debug PTF unreachable issue.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 marked this pull request as ready for review January 12, 2025 00:57
@liuh-80 liuh-80 requested a review from qiluo-msft January 12, 2025 00:57
@@ -90,6 +90,10 @@ def print_logs(duthosts, print_dual_tor_logs=False):
cmds.remove(constants.PRINT_LOGS['mux_status'])
cmds.remove(constants.PRINT_LOGS['mux_config'])

# check PTF device reachability
cmds.append("ping {} -c 1 -W 3".format(ptfhost.mgmt_ip))
Copy link
Contributor

@qiluo-msft qiluo-msft Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mgmt_ip

will it work if mgmt only has ipv6 address? #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, check both IPV4 and IPV6

@@ -90,6 +90,10 @@ def print_logs(duthosts, print_dual_tor_logs=False):
cmds.remove(constants.PRINT_LOGS['mux_status'])
cmds.remove(constants.PRINT_LOGS['mux_config'])

# check PTF device reachability
cmds.append("ping {} -c 1 -W 3".format(ptfhost.mgmt_ip))
cmds.append("traceroute {}".format(ptfhost.mgmt_ip))
Copy link
Contributor

@qiluo-msft qiluo-msft Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mgmt_ip

the same #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit 2b19383 into sonic-net:master Jan 16, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants