[wol test] Fix wol test cases failure due to parameter constrain #16242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Zhijian suggests that skip those tests and wait xichen's PR： #15869 So, close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
When test invalid count and interval, we didn't provide both count and interval parameters, so the test could fail with two scenario, one is failed on parameter constrain that count and interval should be both provided, another is invalid value provided.
We need to narrow down the test failure scenario.
So we add parameter in test to make the parameter constrain satisfied.
Type of change
Back port request
Approach
What is the motivation for this PR?
Test case failed unexpecetd, because of the failure results is more than one.
How did you do it?
Reduce the failure result by providing enough parameter. so there will be only one failure that align with the test case
How did you verify/test it?
Run test on 720dt testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation