Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collect based on tenant id #104

Merged
merged 17 commits into from
Oct 17, 2023
Merged

collect based on tenant id #104

merged 17 commits into from
Oct 17, 2023

Conversation

meln1k
Copy link
Member

@meln1k meln1k commented Oct 13, 2023

Description

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with nox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

aquamatthias
aquamatthias reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added a couple of questions/comments.
Maybe we can separate the logic of AccountCollectInProgress and write a test for it?

fixbackend/dispatcher/next_run_repository.py Outdated Show resolved Hide resolved
fixbackend/app.py Outdated Show resolved Hide resolved
fixbackend/dispatcher/dispatcher_service.py Outdated Show resolved Hide resolved
fixbackend/dispatcher/dispatcher_service.py Outdated Show resolved Hide resolved
fixbackend/dispatcher/dispatcher_service.py Show resolved Hide resolved
fixbackend/dispatcher/dispatcher_service.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias reviewed Oct 17, 2023
View reviewed changes
fixbackend/app.py Show resolved Hide resolved
fixbackend/dispatcher/dispatcher_service.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@meln1k meln1k merged commit 5197580 into main Oct 17, 2023
2 checks passed
@meln1k meln1k deleted the nm/send-domain-events-on-tenant-collection branch October 17, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquamatthias aquamatthias aquamatthias approved these changes

@lloesche lloesche Awaiting requested review from lloesche lloesche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meln1k @aquamatthias