Update template_funcs.go #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
davidjumani
previously approved these changes
Nov 14, 2024
jenshu
reviewed
Nov 14, 2024
jenshu
reviewed
Nov 14, 2024
jenshu
approved these changes
Nov 14, 2024
davidjumani
approved these changes
Nov 14, 2024
soloio-bulldozer
bot
deleted the
sheidkamp/support-remove-external-apis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing external API documentation from our docs, so we need to stop linking to them when generating docs from protobufs.
The current solution is to no longer render the link, as there are complications in programmatically determining the correct externally hosted documentation location and version.
Discussion with docs: https://solo-io-corp.slack.com/archives/C03MFATU265/p1731608037978029?thread_ts=1731598700.372589&cid=C03MFATU265
Example change when pulled into
gloo:before:
after
Example usage: solo-io/gloo#10065