Fix duplicate definition of predicate #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
sam-heilbron
approved these changes
Sep 19, 2024
| @@ -17,3 +17,5 @@ func (m *Metadata) Ref() *ResourceRef { | |||
| func (m *Metadata) Match(ref *ResourceRef) bool { | |||
| return m.GetNamespace() == ref.GetNamespace() && m.GetName() == ref.GetName() | |||
| } | |||
|
|
|||
| type Predicate func(metadata *Metadata) bool | |||
There was a problem hiding this comment.
nit: Since this is in the core package, core.Predicate is kind of generic thing. Perhaps we clarify this is a MetadataPredicate?
| - type: FIX | ||
| issueLink: https://github.com/solo-io/gloo/issues/9274 | ||
| resolvesIssue: false | ||
| description: Fixes the issue of multiple declarations of Predicate when multiple snapshots are generated |
There was a problem hiding this comment.
I agree with @nfuden 's point in Slack, could we either inclue the error we see in the PR body, or add a test to show that we can use this Predicate (which would prove that it would work in gloo as well)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue of multiple declarations of Predicate when multiple snapshots are generated
This causes compilation issues after running codegen on the latest v0.35.x
Eg: In gloo OSS when multiple snapshots are created within the same package (discovery snapshot, setup snapshot), multiple
Predicatedefinitions are generated as this is in the _template file.This moves it to the core package to resolve this issue