Move check for test directories (#23)

solo-io · Nov 28, 2022 · ed991ec · ed991ec
1 parent 9d9042d
commit ed991ec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/changelog/v0.1.3/directory_check.yaml b/changelog/v0.1.3/directory_check.yaml
@@ -0,0 +1,5 @@
+changelog:
+  - type: FIX
+    issueLink: https://github.com/solo-io/solo-projects/issues/4191
+    resolvesIssue: false
+    description: Move check for _test and _build directories so that it only occurs when installing from locally built versions.
diff --git a/testutils/helper/install.go b/testutils/helper/install.go
@@ -81,12 +81,12 @@ func NewSoloTestHelper(configFunc TestConfigFunc) (*SoloTestHelper, error) {
 	if configFunc != nil {
 		testConfig = configFunc(defaults)
 	}
-	if err := validateConfig(testConfig); err != nil {
-		return nil, errors.Wrapf(err, "test config validation failed")
-	}
 
 	// Get chart version
 	if testConfig.ReleasedVersion == "" {
+		if err := validateConfig(testConfig); err != nil {
+			return nil, errors.Wrapf(err, "test config validation failed")
+		}
 		version, err := getChartVersion(testConfig)
 		if err != nil {
 			return nil, errors.Wrapf(err, "getting Helm chart version")