Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: Fix Money spec #6068

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Lint: Fix Money spec #6068

merged 1 commit into from
Jan 15, 2025

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jan 15, 2025

Rubocop was understandably not happy about comparing very obviously identical things, so I've made it less obvious by creating a new, identical object.

Rubocop was understandably not happy about comparing very obviously
identical things, so I've made it less obvious by creating a new,
identical object.
@mamhoff mamhoff requested a review from a team as a code owner January 15, 2025 10:02
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jan 15, 2025
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit 332ed17 into solidusio:main Jan 15, 2025
12 of 14 checks passed
@tvdeyen
Copy link
Member

tvdeyen commented Jan 15, 2025

merged because it only impacts CI and unblocks #6064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants