-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Linting runs parallel to testing and circle ci is slow and our free plan has limited resources. Also GH actions are better integrated and has better dev feedback. (cherry picked from commit 7275966) # Conflicts: # .circleci/config.yml
- Loading branch information
Showing
2 changed files
with
62 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
name: Lint | ||
|
||
on: [pull_request] | ||
|
||
concurrency: | ||
group: lint-${{ github.ref_name }} | ||
cancel-in-progress: ${{ github.ref_name != 'main' }} | ||
|
||
permissions: | ||
contents: read | ||
|
||
env: | ||
BUNDLE_ONLY: "lint" | ||
|
||
jobs: | ||
ruby: | ||
name: Check Ruby | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
- name: Install Ruby and gems | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: "3.2" | ||
bundler-cache: true | ||
- name: Lint Ruby files | ||
run: bin/rake lint:rb | ||
- name: Store test results | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: rubocop-results | ||
path: test-results | ||
|
||
erb: | ||
name: Check ERB | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
- name: Install Ruby and gems | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: "3.2" | ||
bundler-cache: true | ||
- name: Lint ERB files | ||
run: bin/rake lint:erb | ||
|
||
javascript: | ||
name: Check JavaScript | ||
runs-on: ubuntu-22.04 | ||
env: | ||
ESLINT_USE_FLAT_CONFIG: false | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Install Ruby and gems | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: "3.2" | ||
bundler-cache: true | ||
- name: Lint JS files | ||
run: bin/rake lint:js |