Optimize StringUtil::url_encode().

sogou · Nov 23, 2024 · e754df7 · e754df7
1 parent 14ac26c
commit e754df7
Showing 1 changed file with 19 additions and 11 deletions.
diff --git a/src/util/StringUtil.cc b/src/util/StringUtil.cc
@@ -92,13 +92,17 @@ std::string StringUtil::url_encode(const std::string& str)
 
 	while (cur < end)
 	{
-		if (*cur == ' ')
-			res += '+';
-		else if (isalnum(*cur) || *cur == '-' || *cur == '_' || *cur == '.' ||
-				 *cur == '!' || *cur == '~' || *cur == '*' || *cur == '\'' ||
-				 *cur == '(' || *cur == ')' || *cur == ':' || *cur == '/' ||
-				 *cur == '@' || *cur == '?' || *cur == '#' || *cur == '&')
+		if (isalnum(*cur) || *cur == '-' || *cur == '_' || *cur == '.' ||
+			*cur == '!' || *cur == '~' || *cur == '*' || *cur == '\'' ||
+			*cur == '(' || *cur == ')' || *cur == ':' || *cur == '/' ||
+			*cur == '@' || *cur == '?' || *cur == '#' || *cur == '&')
+		{
 			res += *cur;
+		}
+		else if (*cur == ' ')
+		{
+			res += '+';
+		}
 		else
 		{
 			res += '%';
@@ -120,12 +124,16 @@ std::string StringUtil::url_encode_component(const std::string& str)
 
 	while (cur < end)
 	{
-		if (*cur == ' ')
-			res += '+';
-		else if (isalnum(*cur) || *cur == '-' || *cur == '_' || *cur == '.' ||
-				 *cur == '!' || *cur == '~' || *cur == '*' || *cur == '\'' ||
-				 *cur == '(' || *cur == ')')
+		if (isalnum(*cur) || *cur == '-' || *cur == '_' || *cur == '.' ||
+			*cur == '!' || *cur == '~' || *cur == '*' || *cur == '\'' ||
+			*cur == '(' || *cur == ')')
+		{
 			res += *cur;
+		}
+		else if (*cur == ' ')
+		{
+			res += '+';
+		}
 		else
 		{
 			res += '%';