Add Actor, external runner and fix flows publisher issues #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emil-bar
force-pushed
the
fix-reactive-publisher-in-flows
branch
from
6453b3b to
3b94895
Compare
emil-bar
changed the title
emil-bar
force-pushed
the
fix-reactive-publisher-in-flows
branch
from
3b94895 to
a7676f3
Compare
adamw
reviewed
Jan 7, 2025
| * ExternalRunner#runAsync(ThrowingConsumer) for running functions within the scope | ||
| */ | ||
| public ExternalRunner externalRunner() { | ||
| if (externalSchedulerActor == null) { |
There was a problem hiding this comment.
this needs concurrent access protection
There was a problem hiding this comment.
Done
I used ReentrantLock instead of Synchronized as it's not pinning the thread (at least in used version) https://stackoverflow.com/a/79304473
adamw
reviewed
Jan 8, 2025
structured/src/main/java/com/softwaremill/jox/structured/Scope.java
Outdated
Show resolved
Hide resolved
adamw
reviewed
Jan 8, 2025
structured/src/main/java/com/softwaremill/jox/structured/Scope.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82