review comments #2

softwaremill · Jan 8, 2025 · 1e25408 · 1e25408
1 parent a5cc213
commit 1e25408
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/structured/src/main/java/com/softwaremill/jox/structured/Scope.java b/structured/src/main/java/com/softwaremill/jox/structured/Scope.java
@@ -123,13 +123,15 @@ public <T> Fork<T> forkUser(Callable<T> f) {
      *  ExternalRunner#runAsync(ThrowingConsumer) for running functions within the scope
      */
     public ExternalRunner externalRunner() {
-        externalSchedulerLock.lock();
-        try {
-            if (externalSchedulerActor == null) {
-                externalSchedulerActor = ActorRef.create(this, r -> r.accept(Scope.this));
+        if (externalSchedulerActor == null) {
+            externalSchedulerLock.lock();
+            try {
+                if (externalSchedulerActor == null) {
+                    externalSchedulerActor = ActorRef.create(this, r -> r.accept(Scope.this));
+                }
+            } finally {
+                externalSchedulerLock.unlock();
             }
-        } finally {
-            externalSchedulerLock.unlock();
         }
         return new ExternalRunner(externalSchedulerActor);
     }