Skip to content

Commit

Permalink
chore(examples): remove dependency on react-native-vector-icons (#2621
Browse files Browse the repository at this point in the history
)

## Description

We no longer use this dependency anywhere.

## Changes

Removed `react-native-vector-icons` and updated lock files.

## Test code and steps to reproduce

CI + run the examples on your local setup

## Checklist

- [ ] Ensured that CI passes
  • Loading branch information
kkafar authored Jan 16, 2025
1 parent e741b8e commit 7dc6916
Show file tree
Hide file tree
Showing 10 changed files with 94 additions and 489 deletions.
34 changes: 14 additions & 20 deletions Example/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1212,7 +1212,7 @@ PODS:
- ReactCommon/turbomodule/core
- react-native-restart (0.0.27):
- React-Core
- react-native-safe-area-context (5.0.0):
- react-native-safe-area-context (5.1.0):
- React-Core
- React-nativeconfig (0.77.0-rc.6)
- React-NativeModulesApple (0.77.0-rc.6):
Expand Down Expand Up @@ -1503,7 +1503,7 @@ PODS:
- React-logger (= 0.77.0-rc.6)
- React-perflogger (= 0.77.0-rc.6)
- React-utils (= 0.77.0-rc.6)
- RNGestureHandler (2.21.2):
- RNGestureHandler (2.22.0):
- DoubleConversion
- glog
- hermes-engine
Expand All @@ -1524,7 +1524,7 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNReanimated (3.16.6):
- RNReanimated (3.16.7):
- DoubleConversion
- glog
- hermes-engine
Expand All @@ -1544,10 +1544,10 @@ PODS:
- ReactCodegen
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- RNReanimated/reanimated (= 3.16.6)
- RNReanimated/worklets (= 3.16.6)
- RNReanimated/reanimated (= 3.16.7)
- RNReanimated/worklets (= 3.16.7)
- Yoga
- RNReanimated/reanimated (3.16.6):
- RNReanimated/reanimated (3.16.7):
- DoubleConversion
- glog
- hermes-engine
Expand All @@ -1567,9 +1567,9 @@ PODS:
- ReactCodegen
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- RNReanimated/reanimated/apple (= 3.16.6)
- RNReanimated/reanimated/apple (= 3.16.7)
- Yoga
- RNReanimated/reanimated/apple (3.16.6):
- RNReanimated/reanimated/apple (3.16.7):
- DoubleConversion
- glog
- hermes-engine
Expand All @@ -1590,7 +1590,7 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNReanimated/worklets (3.16.6):
- RNReanimated/worklets (3.16.7):
- DoubleConversion
- glog
- hermes-engine
Expand All @@ -1611,7 +1611,7 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNScreens (4.4.0):
- RNScreens (4.5.0):
- DoubleConversion
- glog
- hermes-engine
Expand All @@ -1633,8 +1633,6 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNVectorIcons (8.1.0):
- React-Core
- SocketRocket (0.7.1)
- Yoga (0.0.0)

Expand Down Expand Up @@ -1711,7 +1709,6 @@ DEPENDENCIES:
- RNGestureHandler (from `../node_modules/react-native-gesture-handler`)
- RNReanimated (from `../node_modules/react-native-reanimated`)
- RNScreens (from `../node_modules/react-native-screens`)
- RNVectorIcons (from `../node_modules/react-native-vector-icons`)
- Yoga (from `../node_modules/react-native/ReactCommon/yoga`)

SPEC REPOS:
Expand Down Expand Up @@ -1860,8 +1857,6 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native-reanimated"
RNScreens:
:path: "../node_modules/react-native-screens"
RNVectorIcons:
:path: "../node_modules/react-native-vector-icons"
Yoga:
:path: "../node_modules/react-native/ReactCommon/yoga"

Expand Down Expand Up @@ -1903,7 +1898,7 @@ SPEC CHECKSUMS:
React-Mapbuffer: ade5ce90a8643af61bd7365c51a6e957b5722045
React-microtasksnativemodule: c314f95dc827b8fa3765372bb847b477b7663065
react-native-restart: 7595693413fe3ca15893702f2c8306c62a708162
react-native-safe-area-context: ab7beb734b0f9f79f55ae144a6c946a6422f55d6
react-native-safe-area-context: 04803a01f39f31cc6605a5531280b477b48f8a88
React-nativeconfig: b9c086f83aba945dad592d2556fe2b983f541032
React-NativeModulesApple: acb8da00a222da8da6e458a9dfae63cc264780c6
React-perflogger: 85a817dc96114c0df3e0d5a700688cd0a5643a9d
Expand Down Expand Up @@ -1933,10 +1928,9 @@ SPEC CHECKSUMS:
ReactAppDependencyProvider: 3c3394a2c93b03ae9859e02bed235c4d91e31723
ReactCodegen: a6deb0c3df0af4ccc71c9383634833d2ac642002
ReactCommon: f579a0130fb73a351de4723fb33d277c5bf3283d
RNGestureHandler: f353fb56ea8f6c929da175128437cdd3abc0e5f4
RNReanimated: f61d00aa9fb4fec84f7329be9e44d4db65f7fff3
RNScreens: da1dc8c54f52381ebfe1c5fc39a14e6e02dd0fe6
RNVectorIcons: 31cebfcf94e8cf8686eb5303ae0357da64d7a5a4
RNGestureHandler: 8b33b2c5688a54fcce223d184753757da498235c
RNReanimated: 10df3198b328f8a0677fdaaa2b449db53cdbff40
RNScreens: 81237378a6d7921fb2dbb6a6c6c45c3d8cc696bb
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
Yoga: 0c8754b0ea9edb13b6ce6b60f0f69eb5f164f16a

Expand Down
32 changes: 0 additions & 32 deletions Example/ios/ScreensExample.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -392,22 +392,6 @@
inputPaths = (
"${PODS_ROOT}/Target Support Files/Pods-ScreensExample/Pods-ScreensExample-resources.sh",
"${PODS_CONFIGURATION_BUILD_DIR}/RCT-Folly/RCT-Folly_privacy.bundle",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/AntDesign.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/Entypo.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/EvilIcons.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/Feather.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/FontAwesome.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/FontAwesome5_Brands.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/FontAwesome5_Regular.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/FontAwesome5_Solid.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/Fontisto.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/Foundation.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/Ionicons.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/MaterialCommunityIcons.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/MaterialIcons.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/Octicons.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/SimpleLineIcons.ttf",
"${PODS_ROOT}/../../node_modules/react-native-vector-icons/Fonts/Zocial.ttf",
"${PODS_CONFIGURATION_BUILD_DIR}/React-Core/React-Core_privacy.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/React-cxxreact/React-cxxreact_privacy.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/boost/boost_privacy.bundle",
Expand All @@ -416,22 +400,6 @@
name = "[CP] Copy Pods Resources";
outputPaths = (
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/RCT-Folly_privacy.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AntDesign.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/Entypo.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/EvilIcons.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/Feather.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/FontAwesome.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/FontAwesome5_Brands.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/FontAwesome5_Regular.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/FontAwesome5_Solid.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/Fontisto.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/Foundation.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/Ionicons.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/MaterialCommunityIcons.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/MaterialIcons.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/Octicons.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/SimpleLineIcons.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/Zocial.ttf",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/React-Core_privacy.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/React-cxxreact_privacy.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/boost_privacy.bundle",
Expand Down
3 changes: 1 addition & 2 deletions Example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
"react-native-reanimated": "3.16.7",
"react-native-restart": "^0.0.27",
"react-native-safe-area-context": "5.1.0",
"react-native-screens": "link:../",
"react-native-vector-icons": "^8.0.0"
"react-native-screens": "link:../"
},
"resolutions": {
"@react-navigation/core": "link:../react-navigation/packages/core/"
Expand Down
116 changes: 1 addition & 115 deletions Example/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3055,7 +3055,6 @@ __metadata:
react-native-restart: "npm:^0.0.27"
react-native-safe-area-context: "npm:5.1.0"
react-native-screens: "link:../"
react-native-vector-icons: "npm:^8.0.0"
react-test-renderer: "npm:18.3.1"
ts-jest: "npm:^29.0.3"
typescript: "npm:5.0.4"
Expand Down Expand Up @@ -3975,17 +3974,6 @@ __metadata:
languageName: node
linkType: hard

"cliui@npm:^7.0.2":
version: 7.0.4
resolution: "cliui@npm:7.0.4"
dependencies:
string-width: "npm:^4.2.0"
strip-ansi: "npm:^6.0.0"
wrap-ansi: "npm:^7.0.0"
checksum: 10c0/6035f5daf7383470cef82b3d3db00bec70afb3423538c50394386ffbbab135e26c3689c41791f911fa71b62d13d3863c712fdd70f0fbdffd938a1e6fd09aac00
languageName: node
linkType: hard

"cliui@npm:^8.0.1":
version: 8.0.1
resolution: "cliui@npm:8.0.1"
Expand Down Expand Up @@ -7309,41 +7297,13 @@ __metadata:
languageName: node
linkType: hard

"lodash._reinterpolate@npm:^3.0.0":
version: 3.0.0
resolution: "lodash._reinterpolate@npm:3.0.0"
checksum: 10c0/cdf592374b5e9eb6d6290a9a07c7d90f6e632cca4949da2a26ae9897ab13f138f3294fd5e81de3e5d997717f6e26c06747a9ad3413c043fd36c0d87504d97da6
languageName: node
linkType: hard

"lodash.debounce@npm:^4.0.8":
version: 4.0.8
resolution: "lodash.debounce@npm:4.0.8"
checksum: 10c0/762998a63e095412b6099b8290903e0a8ddcb353ac6e2e0f2d7e7d03abd4275fe3c689d88960eb90b0dde4f177554d51a690f22a343932ecbc50a5d111849987
languageName: node
linkType: hard

"lodash.frompairs@npm:^4.0.1":
version: 4.0.1
resolution: "lodash.frompairs@npm:4.0.1"
checksum: 10c0/67cd95a9b04fc776de17c2699822d0a9f748a68d373f2fcfae059b10d5546e4474476f78c7b5d6c2b881a6e058d4dc8c0175147842b875f8626c3ab5cf90981d
languageName: node
linkType: hard

"lodash.isequal@npm:^4.5.0":
version: 4.5.0
resolution: "lodash.isequal@npm:4.5.0"
checksum: 10c0/dfdb2356db19631a4b445d5f37868a095e2402292d59539a987f134a8778c62a2810c2452d11ae9e6dcac71fc9de40a6fedcb20e2952a15b431ad8b29e50e28f
languageName: node
linkType: hard

"lodash.isstring@npm:^4.0.1":
version: 4.0.1
resolution: "lodash.isstring@npm:4.0.1"
checksum: 10c0/09eaf980a283f9eef58ef95b30ec7fee61df4d6bf4aba3b5f096869cc58f24c9da17900febc8ffd67819b4e29de29793190e88dc96983db92d84c95fa85d1c92
languageName: node
linkType: hard

"lodash.memoize@npm:^4.1.2":
version: 4.1.2
resolution: "lodash.memoize@npm:4.1.2"
Expand All @@ -7358,39 +7318,6 @@ __metadata:
languageName: node
linkType: hard

"lodash.omit@npm:^4.5.0":
version: 4.5.0
resolution: "lodash.omit@npm:4.5.0"
checksum: 10c0/3808b9b6faae35177174b6ab327f1177e29c91f1e98dcbccf13a72a6767bba337306449d537a4e0d8a33d2673f10d39bc732e30c4b803274ea0c1168ea60e549
languageName: node
linkType: hard

"lodash.pick@npm:^4.4.0":
version: 4.4.0
resolution: "lodash.pick@npm:4.4.0"
checksum: 10c0/a04c460b95d1aaa44e9513d1dacf72ea74d838da843e45831de9de64c303f13cdde1859702a6f4dcef417816898ffd47c6ae0614c957ac70245bed2809b8d2e2
languageName: node
linkType: hard

"lodash.template@npm:^4.5.0":
version: 4.5.0
resolution: "lodash.template@npm:4.5.0"
dependencies:
lodash._reinterpolate: "npm:^3.0.0"
lodash.templatesettings: "npm:^4.0.0"
checksum: 10c0/62a02b397f72542fa9a989d9fc1a94fc1cb94ced8009fa5c37956746c0cf460279e844126c2abfbf7e235fe27e8b7ee8e6efbf6eac247a06aa05b05457fda817
languageName: node
linkType: hard

"lodash.templatesettings@npm:^4.0.0":
version: 4.2.0
resolution: "lodash.templatesettings@npm:4.2.0"
dependencies:
lodash._reinterpolate: "npm:^3.0.0"
checksum: 10c0/2609fea36ed061114dfed701666540efc978b069b2106cd819b415759ed281419893d40f85825240197f1a38a98e846f2452e2d31c6d5ccee1e006c9de820622
languageName: node
linkType: hard

"lodash.throttle@npm:^4.1.1":
version: 4.1.1
resolution: "lodash.throttle@npm:4.1.1"
Expand Down Expand Up @@ -8772,7 +8699,7 @@ __metadata:
languageName: node
linkType: hard

"prop-types@npm:^15.7.2, prop-types@npm:^15.8.1":
"prop-types@npm:^15.8.1":
version: 15.8.1
resolution: "prop-types@npm:15.8.1"
dependencies:
Expand Down Expand Up @@ -8944,25 +8871,6 @@ __metadata:
languageName: node
linkType: soft

"react-native-vector-icons@npm:^8.0.0":
version: 8.1.0
resolution: "react-native-vector-icons@npm:8.1.0"
dependencies:
lodash.frompairs: "npm:^4.0.1"
lodash.isequal: "npm:^4.5.0"
lodash.isstring: "npm:^4.0.1"
lodash.omit: "npm:^4.5.0"
lodash.pick: "npm:^4.4.0"
lodash.template: "npm:^4.5.0"
prop-types: "npm:^15.7.2"
yargs: "npm:^16.1.1"
bin:
fa5-upgrade: bin/fa5-upgrade.sh
generate-icon: bin/generate-icon.js
checksum: 10c0/b42d6a0bcace45440d42c5a852081c8a25c1c3324dfc431c530dd155e4f60f2b25f7c3299df921ea3632eb1007715739dbb169621948b01861348dab0dff5d18
languageName: node
linkType: hard

"react-native@npm:0.77.0-rc.6":
version: 0.77.0-rc.6
resolution: "react-native@npm:0.77.0-rc.6"
Expand Down Expand Up @@ -10931,13 +10839,6 @@ __metadata:
languageName: node
linkType: hard

"yargs-parser@npm:^20.2.2":
version: 20.2.9
resolution: "yargs-parser@npm:20.2.9"
checksum: 10c0/0685a8e58bbfb57fab6aefe03c6da904a59769bd803a722bb098bd5b0f29d274a1357762c7258fb487512811b8063fb5d2824a3415a0a4540598335b3b086c72
languageName: node
linkType: hard

"yargs-parser@npm:^21.0.0, yargs-parser@npm:^21.1.1":
version: 21.1.1
resolution: "yargs-parser@npm:21.1.1"
Expand Down Expand Up @@ -10976,21 +10877,6 @@ __metadata:
languageName: node
linkType: hard

"yargs@npm:^16.1.1":
version: 16.2.0
resolution: "yargs@npm:16.2.0"
dependencies:
cliui: "npm:^7.0.2"
escalade: "npm:^3.1.1"
get-caller-file: "npm:^2.0.5"
require-directory: "npm:^2.1.1"
string-width: "npm:^4.2.0"
y18n: "npm:^5.0.5"
yargs-parser: "npm:^20.2.2"
checksum: 10c0/b1dbfefa679848442454b60053a6c95d62f2d2e21dd28def92b647587f415969173c6e99a0f3bab4f1b67ee8283bf735ebe3544013f09491186ba9e8a9a2b651
languageName: node
linkType: hard

"yargs@npm:^17.0.0, yargs@npm:^17.3.1, yargs@npm:^17.6.2":
version: 17.7.2
resolution: "yargs@npm:17.7.2"
Expand Down
Loading

0 comments on commit 7dc6916

Please sign in to comment.