Track proc macro server status in analysis progress #270
Conversation
Arcticae
requested review from
mkaput and
Draggu
and removed request for
a team
| use std::sync::atomic::{AtomicBool, Ordering}; | ||
| use std::sync::{Arc, Mutex}; | ||
|
|
||
| use crate::config::Config; | ||
| use crate::lsp::ext::{ServerStatus, ServerStatusEvent, ServerStatusParams}; | ||
| use crate::server::client::Notifier; | ||
|
|
||
| #[derive(Clone, PartialEq)] | ||
| pub enum ProcMacroServerStatus { |
There was a problem hiding this comment.
I don't really care if it's crashed tbh - i do care about the startup status
There was a problem hiding this comment.
I did it anyway, for consistency sake
src/lang/proc_macros/controller.rs
Outdated
| @@ -148,6 +148,7 @@ impl ProcMacroClientController { | |||
| } | |||
|
|
|||
| db.set_proc_macro_client_status(ClientStatus::Ready(client)); | |||
| self.proc_macro_server_tracker.set_server_status(ProcMacroServerStatus::Ready) | |||
There was a problem hiding this comment.
Make func to set db.set_proc_macro_client_status and proc_macro_server_tracker.set_server_status, this will be easy to forget when changing this code.
Also, you can create ProcMacroServerStatus from &ClientStatus
There was a problem hiding this comment.
what about this?
db.set_proc_macro_client_status(ClientStatus::Ready(client));
self.proc_macro_server_tracker.pull_status_from_db(&db);?
There was a problem hiding this comment.
But you still have to remember to call both
There was a problem hiding this comment.
that's true. I can't think of another way to set up a "watcher" behaviour on this
| proc_macro_server_tracker: ProcMacroServerTracker, | ||
| } | ||
|
|
||
| impl From<&ClientStatus> for ProcMacroServerStatus { |
There was a problem hiding this comment.
Shouldn't we rename ClientStatus to ServerStatus at this point? cc @Draggu
| @@ -96,6 +107,12 @@ impl ProcMacroClientController { | |||
| } | |||
| } | |||
|
|
|||
| fn set_procmacro_client_status(&self, db: &mut AnalysisDatabase, client_status: ClientStatus) { | |||
There was a problem hiding this comment.
| fn set_procmacro_client_status(&self, db: &mut AnalysisDatabase, client_status: ClientStatus) { | |
| fn set_proc_macro_client_status(&self, db: &mut AnalysisDatabase, client_status: ClientStatus) { |
[nit]
Stack:
⬆️ #271