[All] Refactor create/cancreate in ObjectFactory

Sofa/Component/Collision/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/BruteForceDetection.h

@@ -40,6 +40,8 @@ class SOFA_COMPONENT_COLLISION_DETECTION_ALGORITHM_API BruteForceDetection final
     template<class T>
     static typename T::SPtr create(T*, sofa::core::objectmodel::BaseContext* context, sofa::core::objectmodel::BaseObjectDescription* arg)
     {
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // this one is funny as it behave like a Prefab, thus creating and adding other component in the graph.
         if (context)
         {
             if (const BruteForceBroadPhase::SPtr broadPhase = sofa::core::objectmodel::New<BruteForceBroadPhase>())

Sofa/Component/Collision/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/DirectSAP.h

@@ -41,6 +41,8 @@ class SOFA_COMPONENT_COLLISION_DETECTION_ALGORITHM_API DirectSAP final : public
     template<class T>
     static typename T::SPtr create(T*, sofa::core::objectmodel::BaseContext* context, sofa::core::objectmodel::BaseObjectDescription* arg)
     {
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // this one is funny as it behave like a Prefab, thus creating and adding other component in the graph.
         if (context)
         {
             if (const BruteForceBroadPhase::SPtr broadPhase = sofa::core::objectmodel::New<BruteForceBroadPhase>())

Sofa/Component/Collision/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/RayTraceDetection.h

@@ -47,6 +47,8 @@ class SOFA_COMPONENT_COLLISION_DETECTION_ALGORITHM_API RayTraceDetection final :
     template<class T>
     static typename T::SPtr create(T*, sofa::core::objectmodel::BaseContext* context, sofa::core::objectmodel::BaseObjectDescription* arg)
     {
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // this one is funny as it behave like a Prefab, thus creating and adding other component in the graph.
         const BruteForceBroadPhase::SPtr broadPhase = sofa::core::objectmodel::New<BruteForceBroadPhase>();
         broadPhase->setName("bruteForceBroadPhase");
         if (context) context->addObject(broadPhase);

Sofa/Component/Collision/Geometry/src/sofa/component/collision/geometry/LineModel.h

@@ -161,7 +161,7 @@ public :
                           "' found in the context node.");
             return false;
         }
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     sofa::core::topology::BaseMeshTopology* getCollisionTopology() override

Sofa/Component/Collision/Geometry/src/sofa/component/collision/geometry/PointModel.h

@@ -120,7 +120,7 @@ class PointCollisionModel : public core::CollisionModel
                           "' found in the context node.");
             return false;
         }
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     void computeBBox(const core::ExecParams* params, bool onlyVisible) override;

Sofa/Component/Collision/Geometry/src/sofa/component/collision/geometry/SphereModel.h

@@ -136,14 +136,16 @@ class SphereCollisionModel : public core::CollisionModel
             return false;
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     template<class T>
     static typename T::SPtr create(T*, core::objectmodel::BaseContext* context, core::objectmodel::BaseObjectDescription* arg)
     {
         typename T::SPtr obj;
 
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // duplicated code, path and context searching for states (probably to move into init)
         if( context)
         {
             auto* _mstate = dynamic_cast<core::behavior::MechanicalState<TDataTypes>*>(context->getMechanicalState());

Sofa/Component/Collision/Geometry/src/sofa/component/collision/geometry/TriangleModel.h

@@ -208,7 +208,7 @@ class TriangleCollisionModel : public core::CollisionModel
                           "' found in the context node.");
             return false;
         }
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     void computeBBox(const core::ExecParams* params, bool onlyVisible=false) override;

Sofa/Component/Collision/Response/Contact/src/sofa/component/collision/response/contact/CollisionResponse.h

@@ -56,6 +56,8 @@ public :
     template<class T>
     static typename T::SPtr create(T*, core::objectmodel::BaseContext* context, core::objectmodel::BaseObjectDescription* arg)
     {
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // not sure how to handle this one...
         typename T::SPtr obj = sofa::core::objectmodel::New<T>();
         if (context)
         {

Sofa/Component/Collision/Response/Contact/src/sofa/component/collision/response/contact/ContactListener.h

@@ -104,12 +104,15 @@ class SOFA_COMPONENT_COLLISION_RESPONSE_CONTACT_API ContactListener : public vir
             return false;
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     template<class T>
     static typename T::SPtr create(T* , core::objectmodel::BaseContext* context, core::objectmodel::BaseObjectDescription* arg)
     {
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // it seems there is some creative attribute hacking in this one. See if the behavior can be reimplemented
+        // using a mix of parse/init
         core::CollisionModel* collModel1 = nullptr;
         core::CollisionModel* collModel2 = nullptr;
 

Sofa/Component/Engine/Analyze/src/sofa/component/engine/analyze/Distances.h

@@ -191,7 +191,7 @@ class Distances : public core::DataEngine
             arg->logError("Data attribute 'targetPath' does not point to a mechanical state of data type '" + std::string(DataTypes::Name()) +"'.");
             error = true;
         }
-        return !error && core::DataEngine::canCreate(obj, context, arg);
+        return !error;
     }
     /// Construction method called by ObjectFactory.
     ///
@@ -200,6 +200,9 @@ class Distances : public core::DataEngine
     template<class T>
     static typename T::SPtr create(T*, core::objectmodel::BaseContext* context, core::objectmodel::BaseObjectDescription* arg )
     {
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // probably remove the constructor with arguments and replace that with SinglLink to delegate at
+        // init/parse the initiatilization.
         typename T::SPtr obj = sofa::core::objectmodel::New<T>(
                 ( arg?dynamic_cast<sofa::component::topology::container::dynamic::DynamicSparseGridTopologyContainer*> ( arg->findObject ( arg->getAttribute ( "hexaContainerPath","../.." ) ) ) :nullptr ),
                 ( arg?dynamic_cast<core::behavior::MechanicalState<DataTypes>*> ( arg->findObject ( arg->getAttribute ( "targetPath",".." ) ) ) :nullptr ) );

Sofa/Component/Engine/Select/src/sofa/component/engine/select/PairBoxRoi.h

@@ -84,7 +84,7 @@ class PairBoxROI : public core::DataEngine
             }
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 protected:

Sofa/Component/Engine/Select/src/sofa/component/engine/select/PlaneROI.h

@@ -88,7 +88,7 @@ class PlaneROI : public core::DataEngine
             }
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 protected:

Sofa/Component/Engine/Select/src/sofa/component/engine/select/ProximityROI.h

@@ -82,7 +82,7 @@ class ProximityROI : public core::DataEngine
             }
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 public:

Sofa/Component/Engine/Select/src/sofa/component/engine/select/SubsetTopology.h

@@ -89,7 +89,7 @@ class SubsetTopology : public core::DataEngine
             }
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 protected:

Sofa/Component/Engine/Select/src/sofa/component/engine/select/ValuesFromPositions.h

@@ -86,7 +86,7 @@ class ValuesFromPositions : public core::DataEngine
             }
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 protected:

Sofa/Component/Haptics/src/sofa/component/haptics/LCPForceFeedback.h

@@ -115,7 +115,7 @@ class LCPForceFeedback : public MechanicalStateForceFeedback<TDataTypes>
             return false;
         }
 
-        return core::objectmodel::BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     /// Override method to lock or unlock the force feedback computation. According to parameter, value == true (resp. false) will lock (resp. unlock) mutex @sa lockForce

Sofa/Component/IO/Mesh/src/sofa/component/io/mesh/BlenderExporter.h

@@ -123,7 +123,7 @@ class SOFA_COMPONENT_IO_MESH_API BlenderExporter: public core::objectmodel::Base
                           "' found in the context node.");
             return false;
         }
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 protected:

Sofa/Component/LinearSolver/Preconditioner/src/sofa/component/linearsolver/preconditioner/PrecomputedWarpPreconditioner.h

@@ -166,7 +166,7 @@ class PrecomputedWarpPreconditioner : public sofa::component::linearsolver::Matr
             arg->logError(std::string("No mechanical state with the datatype '") + TDataTypes::Name() + "' found in the context node.");
             return false;
         }
-        return sofa::core::objectmodel::BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 protected :

Sofa/Component/Playback/src/sofa/component/playback/CompareState.h

@@ -57,7 +57,7 @@ class SOFA_COMPONENT_PLAYBACK_API CompareState: public ReadState
             arg->logError("No mechanical state found in the context node.");
             return false;
         }
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     /// Return the total errors (position and velocity)

Sofa/Component/Playback/src/sofa/component/playback/CompareTopology.h

@@ -57,7 +57,7 @@ class SOFA_COMPONENT_PLAYBACK_API CompareTopology: public ReadTopology
             arg->logError("Cannot find a mesh topology in the current context");
             return false;
         }
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     /// Return the total number of errors

Sofa/Component/Playback/src/sofa/component/playback/ReadState.h

@@ -91,7 +91,7 @@ class SOFA_COMPONENT_PLAYBACK_API ReadState: public core::objectmodel::BaseObjec
             arg->logError("No mechanical state found in the context node.");
             return false;
         }
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 

Sofa/Component/Playback/src/sofa/component/playback/ReadTopology.h

@@ -104,7 +104,7 @@ class SOFA_COMPONENT_PLAYBACK_API ReadTopology: public core::objectmodel::BaseOb
             return false;
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 

Sofa/Component/Playback/src/sofa/component/playback/WriteState.h

@@ -103,7 +103,7 @@ class SOFA_COMPONENT_PLAYBACK_API WriteState: public core::objectmodel::BaseObje
             arg->logError("No mechanical state found in the context node.");
             return false;
         }
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 };

Sofa/Component/Playback/src/sofa/component/playback/WriteTopology.h

@@ -114,7 +114,7 @@ class SOFA_COMPONENT_PLAYBACK_API WriteTopology: public core::objectmodel::BaseO
             return false;
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
 };

Sofa/Component/Topology/Container/Dynamic/src/sofa/component/topology/container/dynamic/PointSetGeometryAlgorithms.h

@@ -101,7 +101,7 @@ class PointSetGeometryAlgorithms : public core::topology::GeometryAlgorithms
                           "' found in the context node.");
             return false;
         }
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     /** \brief Called by the state change callback to initialize added

Sofa/Component/Topology/Utility/src/sofa/component/topology/utility/TopologicalChangeProcessor.h

@@ -180,7 +180,7 @@ class SOFA_COMPONENT_TOPOLOGY_UTILITY_API TopologicalChangeProcessor: public cor
             return false;
         }
 
-        return BaseObject::canCreate(obj, context, arg);
+        return true;
     }
 
     void draw(const core::visual::VisualParams* vparams) override;

Sofa/framework/Core/src/sofa/core/Mapping.h

@@ -229,7 +229,7 @@ class Mapping : public BaseMapping
             return false;
         }
 
-        return BaseMapping::canCreate(obj, context, arg);
+        return true;
     }
 
     /// Construction method called by ObjectFactory.
@@ -239,6 +239,9 @@ class Mapping : public BaseMapping
     template<class T>
     static typename T::SPtr create(T*, core::objectmodel::BaseContext* context, core::objectmodel::BaseObjectDescription* arg)
     {
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // it seems there is some creative attribute hacking in this one. See if we can implement similar
+        // behavior using parse/init()
         typename T::SPtr obj = sofa::core::objectmodel::New<T>();
 
         if (context)

Sofa/framework/Core/src/sofa/core/Multi2Mapping.h

@@ -227,7 +227,7 @@ class Multi2Mapping : public BaseMapping
             error = true;
         }
 
-        return !error && BaseMapping::canCreate(obj, context, arg);
+        return !error;
     }
     /// Construction method called by ObjectFactory.
     ///
@@ -236,6 +236,8 @@ class Multi2Mapping : public BaseMapping
     template<class T>
     static typename T::SPtr create(T*, core::objectmodel::BaseContext* context, core::objectmodel::BaseObjectDescription* arg)
     {
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // trivial remplacement (remarkably inconstitant behavior with the one implemented in Mapping::create)
         typename T::SPtr obj = sofa::core::objectmodel::New<T>();
 
         if (context)

Sofa/framework/Core/src/sofa/core/MultiMapping.h

@@ -228,7 +228,7 @@ class MultiMapping : public BaseMapping
             return false;
         }
 
-        return BaseMapping::canCreate(obj, context, arg);
+        return true;
     }
 
     /// Construction method called by ObjectFactory.
@@ -238,6 +238,8 @@ class MultiMapping : public BaseMapping
     template<class T>
     static typename T::SPtr create(T*, core::objectmodel::BaseContext* context, core::objectmodel::BaseObjectDescription* arg)
     {
+        // TODO(dmarchal, 08/01/2025): Update the create function to the new factory creation process.
+        // trivial remplacement (remarkably inconstitant behavior with the one implemented in Mapping::create)
         typename T::SPtr obj = sofa::core::objectmodel::New<T>();
 
         if (context)

Sofa/framework/Core/src/sofa/core/ObjectFactory.cpp

@@ -139,6 +139,20 @@ void findTemplatedCreator(
     }
 }
 
+void ObjectFactory::postObjectCreation(sptr<objectmodel::BaseObject> obj, objectmodel::BaseContext* context, objectmodel::BaseObjectDescription* arg)
+{
+    if (context)
+    {
+        context->addObject(obj);
+    }
+
+    if (arg)
+    {
+        obj->parse(arg);
+    }
+}
+
+
 objectmodel::BaseObject::SPtr ObjectFactory::createObject(objectmodel::BaseContext* context, objectmodel::BaseObjectDescription* arg)
 {
     objectmodel::BaseObject::SPtr object = nullptr;