Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Engine.Select] Automatically find topology in MeshBoundaryROI #5116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Engine.Select] Automatically find topology in MeshBoundaryROI #5116

wants to merge 1 commit into from

Conversation

alxbilger
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Nov 14, 2024
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@bakpaul
Copy link
Contributor

bakpaul commented Nov 18, 2024

Do we really want to make it automatically ? I guess, it is better to make sure the user knows what he is doing ? MAybe set the ComponentState to invalid instead ?

@alxbilger
Copy link
Contributor Author

Do we really want to make it automatically ? I guess, it is better to make sure the user knows what he is doing ? MAybe set the ComponentState to invalid instead ?

I wondered the same question, but I chose consistency with the other ROIs over explicit link setting. Let's decide together.

@bakpaul bakpaul added this to the v25.06 milestone Dec 16, 2024
hugtalbot
hugtalbot reviewed Dec 18, 2024
View reviewed changes
Sofa/Component/Engine/Select/src/sofa/component/engine/select/MeshBoundaryROI.cpp
core::topology::BaseMeshTopology* topology = nullptr;
this->getContext()->get(topology, core::objectmodel::BaseContext::Local);

if (topology)
Copy link
Contributor

@hugtalbot hugtalbot Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an error if not found?
+ invalid component state

@alxbilger alxbilger added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jan 8, 2025
@alxbilger
Copy link
Contributor Author

From the dev meeting;

Apply same mechanism as what is currently done in SOFA: keep the automatic search. Need to check if pointer is not null. Add warning at the end of Init if no topology is found and not data is set (as in BaseROI). Later remove all implicit search and only use input data and rely on user to input the data correctly. → wip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot left review comments

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: status wip Development in the pull-request is still in progress
Projects
None yet
Milestone
v25.06
Development

Successfully merging this pull request may close these issues.
3 participants
@alxbilger @bakpaul @hugtalbot