Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix isSet flag when setting a link to a not-yet created data #5081

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Oct 23, 2024

In SimpleAPI and SofaPython3 (surely XML too),
if a data link is set to a data of a not-yet created BaseObject, isSet is not true.

In the newly created tests, the last one would be false without the fix in BaseData


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: test PR adding test(s) in SOFA labels Oct 23, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Oct 23, 2024

[ci-build][with-all-tests]

@alxbilger
Copy link
Contributor

Is this related to #4910?

@hugtalbot
Copy link
Contributor

This should fix #4911

@fredroy
Copy link
Contributor Author

fredroy commented Oct 23, 2024

Is this related to #4910?

Maybe but It was not my intention 😅 I got the problem in SofaPython3 for our own component.

This should fix #4911

It would have been convenient to have a test related to this problem 👼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: test PR adding test(s) in SOFA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants