-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workflow][Nix] initial packaging & flake #5059
Open
nim65s
wants to merge
10
commits into
sofa-framework:master
Choose a base branch
from
nim65s:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a993b27 - Browse repository at this point
Copy the full SHA a993b27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86913f6 - Browse repository at this point
Copy the full SHA 86913f6View commit details -
[CMake] FindQGLViewer: fix include dir computation
we use `#include <QGLViewer/qglviewer.h>`, so `QGLViewer_INCLUDE_DIR` must not include `QGLViewer` component. Also, on darwin, headers are installed in Headers dir, not include, ref: https://github.com/GillesDebunne/libQGLViewer/blob/ba9a875784afbb7ee73088fe0e8701c31bc7277d/QGLViewer/QGLViewer.pro#L138
Configuration menu - View commit details
-
Copy full SHA for e51daca - Browse repository at this point
Copy the full SHA e51dacaView commit details
Commits on Oct 16, 2024
-
This require fixes in upstream nixpkgs: NixOS/nixpkgs#348549 So we can use the source of that PR for now
Configuration menu - View commit details
-
Copy full SHA for 1708b79 - Browse repository at this point
Copy the full SHA 1708b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for a03a458 - Browse repository at this point
Copy the full SHA a03a458View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c3bfb7 - Browse repository at this point
Copy the full SHA 6c3bfb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd261b5 - Browse repository at this point
Copy the full SHA bd261b5View commit details -
[CMake] fix SOFA_GUI_QT_HAVE_QT6 definition
without this, `lib/cmake/Sofa.GUI.Qt/Sofa.GUI.QtConfig.cmake` has: > `set(SOFA_GUI_QT_HAVE_QT6 0)` and therefore, in SofaPython3, `find_package(QGLViewer QUIET REQUIRED)` is not called, and build ends up with: > [ 98%] Linking CXX shared library ../../lib/python3/site-packages/Sofa/Gui.cpython-312-x86_64-linux-gnu.so > […]/ld: cannot find -lQGLViewer: No such file or directory
Configuration menu - View commit details
-
Copy full SHA for 6489fd1 - Browse repository at this point
Copy the full SHA 6489fd1View commit details -
[Nix] fixup lib path on Darwin
TODO: This should be fixed in CMake instead, but I have no clue. error was: > dyld[61665]: Library not loaded: /nix/store/aalbn4pznxwy18ydjmb15c3y4izj8isi-sofa-24.06.00/lib/libSceneChecking.24.12.99.dylib > Referenced from: <8B75C775-7FE5-3755-A190-B11A3F4F6666> /nix/store/aalbn4pznxwy18ydjmb15c3y4izj8isi-sofa-24.06.00/bin/.runSofa-24.12.99-wrapped > Reason: tried: '/nix/store/aalbn4pznxwy18ydjmb15c3y4izj8isi-sofa-24.06.00/lib/libSceneChecking.24.12.99.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/nix/store/aalbn4pznxwy18ydjmb15c3y4izj8isi-sofa-24.06.00/lib/libSceneChecking.24.12.99.dylib' (no such file), '/nix/store/aalbn4pznxwy18ydjmb15c3y4izj8isi-sofa-24.06.00/lib/libSceneChecking.24.12.99.dylib' (no such file), '/usr/local/lib/libSceneChecking.24.12.99.dylib' (no such file), '/usr/lib/libSceneChecking.24.12.99.dylib' (no such file, not in dyld cache) > zsh: abort ./result/bin/runSofa
Configuration menu - View commit details
-
Copy full SHA for f9cfcd0 - Browse repository at this point
Copy the full SHA f9cfcd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8808d24 - Browse repository at this point
Copy the full SHA 8808d24View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.