Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VolumetricRendering] Fix the compilation #4398

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

alxbilger
Copy link
Contributor

But scenes crash

Before going further with #4395, it is wiser to first fix the compilation of the plugin. We can even wonder if we keep this plugin since it has not been maintained for a while.

Note that this plugin is not compiled on the CI. See sofa-framework/ci#32


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Dec 20, 2023
@alxbilger
Copy link
Contributor Author

@fredroy thanks for the PR but I still crash in applications/plugins/VolumetricRendering/examples/OglTetrahedralModel.scn and applications/plugins/VolumetricRendering/examples/OglVolumetricModel_hexa.scn.

@alxbilger
Copy link
Contributor Author

@fredroy Yeah! The scene no longer crashes! But I have the following errors:

[ERROR]   [GLSLShader] ERROR: Compilation of Fragment shader failed:
[ERROR]   [GLSLShader] From File: C:\Users\Alex\Dev\sofa1\src\applications\plugins\VolumetricRendering\examples/share/shaders/tetra.frag
[ERROR]   [GLSLShader] 0(8) : warning C7555: 'varying' is deprecated, use 'in/out' instead
0(16) : error C7616: global variable gl_Color is removed after version 140
0(35) : warning C7533: global variable gl_FragColor is deprecated after version 120

[ERROR]   [GLSLShader] ERROR: Compilation of Vertex shader failed:
[ERROR]   [GLSLShader] From File: C:\Users\Alex\Dev\sofa1\src\applications\plugins\VolumetricRendering\examples/share/shaders/tetra.vert
[ERROR]   [GLSLShader] 0(20) : error C7616: global variable gl_ModelViewProjectionMatrix is removed after version 140
0(23) : error C7616: global variable gl_ClipVertex is removed after version 140
0(23) : error C7616: global variable gl_ModelViewMatrix is removed after version 140
0(23) : error C7616: global variable gl_Vertex is removed after version 140

[ERROR]   [GLSLShader] ERROR: Compilation of Geometry shader failed:
[ERROR]   [GLSLShader] From File: C:\Users\Alex\Dev\sofa1\src\applications\plugins\VolumetricRendering\examples/share/shaders/tetra_triangles.geo
[ERROR]   [GLSLShader] 0(45) : warning C7533: global variable gl_FrontColor is deprecated after version 120
0(46) : error C7616: global variable gl_ClipVertex is removed after version 140

[ERROR]   [GLSLShader] SHADER compilation failed.
[ERROR]   [OglFloat4Attribute(OglFloat4Attribute1)] Variable "a_vertexColor" NOT FOUND in shader "[ 'share/shaders/tetra.vert' ]"
[ERROR]   [Node()] Object 'OglFloat4Attribute1' already has a node (/OglFloat4Attribute1). Please remove it from this node before adding it to a new one.
[ERROR]   [OglFloat4Attribute(OglFloat4Attribute1)] TopologyData: value already has a TopologyDataHandler. createTopologyHandler should only be called once at init of the TopologyData.
[ERROR]   [OglFloat4Attribute(OglFloat4Attribute1)] Variable "a_vertexColor" NOT FOUND in shader "[ 'share/shaders/tetra.vert' ]"

I guess the shaders needs to be updated for version >= 140

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 3, 2024
@hugtalbot hugtalbot merged commit 9a107f7 into sofa-framework:master Jan 5, 2024
5 of 11 checks passed
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v24.06 milestone Jan 10, 2024
@hugtalbot hugtalbot added the pr: backport todo This PR will be backported into the release preceeding its milestone. label Feb 19, 2024
@bakpaul bakpaul modified the milestones: v24.06, v23.12 Feb 19, 2024
bakpaul pushed a commit that referenced this pull request Feb 19, 2024
* [VolumetricRendering] Fix the compilation

But scenes crash

* reflect changes from datatype change for vec3state (#6)

* fix lots of stuff (#7)

---------

Co-authored-by: Frederick Roy <[email protected]>
Co-authored-by: Hugo <[email protected]>
@bakpaul bakpaul added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants