Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Fix compilation using QDocBrowser #4354

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[GUI] Fix compilation using QDocBrowser #4354

merged 1 commit into from
Dec 14, 2023

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Dec 12, 2023

FIX qt target handling.
The QT_TARGETS variable used to store qt targets that the project depends on, was overridden by the libQGLViewer CMakeLists.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: backport todo This PR will be backported into the release preceeding its milestone. labels Dec 12, 2023
@alxbilger
Copy link
Contributor

[ci-build][with-all-tests]

@hugtalbot hugtalbot changed the title [GUI] FIX QDocBrowser [GUI] Fix compilation using QDocBrowser Dec 13, 2023
@fredroy fredroy added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Dec 13, 2023
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 14, 2023
@hugtalbot hugtalbot merged commit f8653f1 into sofa-framework:master Dec 14, 2023
12 checks passed
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v23.12 milestone Jan 10, 2024
@bakpaul bakpaul added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v23.12
Development

Successfully merging this pull request may close these issues.
4 participants
@bakpaul @alxbilger @hugtalbot @fredroy