Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Examples] Fix & Clean ProjectToPlaneConstraint and RegularGridTopology_dimension scenes #3453

Merged
merged 1 commit into from
Nov 4, 2022
Merged

[Examples] Fix & Clean ProjectToPlaneConstraint and RegularGridTopology_dimension scenes #3453

merged 1 commit into from
Nov 4, 2022

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Nov 3, 2022

  • Result for RegularGridTopology_dimension.scn -> showing how to create, 3D (Hexa), 2D (Quad) or 1D (Line) grid.

RegularGridTopology_dimension_00000001

  • Result for ProjectToPlaneConstraint.scn -> not 100% sure about the expected behavior, but at least there is no error/warning and it is moving ! (constrained by the Plane on the left)

ProjectToPlaneConstraint_00000001

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Nov 3, 2022
@epernod
Copy link
Contributor Author

epernod commented Nov 3, 2022

Those scene are failing in PR #3339 but from my understanding they were broken since a long time. The PR just reveal their failure.

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 3, 2022
@fredroy
Copy link
Contributor

fredroy commented Nov 4, 2022

[ci-build][with-all-tests]

@fredroy fredroy merged commit a44cded into sofa-framework:master Nov 4, 2022
@fredroy fredroy mentioned this pull request Nov 4, 2022
Merged
@epernod epernod deleted the inf_fix_examples branch November 4, 2022 08:38
@hugtalbot hugtalbot added this to the v22.12 milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v22.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @fredroy @hugtalbot