Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Topology] Add function in BaseMeshTopology to compute all topology containers #3368

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[Topology] Add function in BaseMeshTopology to compute all topology containers #3368

wants to merge 5 commits into from
+102 −41

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Oct 8, 2022 •
edited
Loading

  • Rename method initTopology already present in XXSetTopologyContainer classes into initContainers
  • Add virtual method in BaseMeshTopology
  • Add Override method implementation in MeshTopology
  • Fix use case in ParallelBVHNarrowPhase

This should fix #2063

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Oct 8, 2022
@epernod
Copy link
Contributor Author

epernod commented Oct 8, 2022

[ci-build][with-all-tests]

@fredroy
Copy link
Contributor

fredroy commented Oct 19, 2022

[ci-build][with-all-tests]

@alxbilger
Copy link
Contributor

TEst to fix

@alxbilger
Copy link
Contributor

Conflicts to solve @epernod

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Oct 26, 2022
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Oct 31, 2022
@epernod
Copy link
Contributor Author

epernod commented Oct 31, 2022

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Nov 2, 2022
@epernod epernod mentioned this pull request Nov 2, 2022
Merged
@hugtalbot hugtalbot changed the title [Topology] Add fonction in BaseMeshTopology to compute all topology containers [Topology] Add function in BaseMeshTopology to compute all topology containers Jan 11, 2023
@alxbilger
Copy link
Contributor

@epernod Hello!

@epernod epernod self-assigned this Sep 6, 2023
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Apr 9, 2024
@epernod
Copy link
Contributor Author

epernod commented Apr 9, 2024

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Apr 10, 2024
@epernod epernod removed the pr: status wip Development in the pull-request is still in progress label Apr 10, 2024
@epernod epernod added the pr: status to review To notify reviewers to review this pull-request label Apr 10, 2024
@epernod epernod mentioned this pull request Apr 10, 2024
Open
8 tasks
@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Apr 10, 2024
@epernod
Copy link
Contributor Author

epernod commented Apr 17, 2024

All tests not working are due to input mesh with an inconstant input mesh.
Like Quad without edges, or list of quads and edges only on border, etc...

what should we do?

@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Apr 17, 2024
@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. and removed pr: status to review To notify reviewers to review this pull-request labels May 7, 2024
@hugtalbot hugtalbot added the STC#17 Tasks for STC#17 coding sprint label May 23, 2024
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 5, 2024
@epernod
Copy link
Contributor Author

epernod commented Sep 5, 2024

[ci-build][with-all-tests]

@epernod epernod marked this pull request as draft September 18, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmarchal damienmarchal damienmarchal left review comments

@hugtalbot hugtalbot hugtalbot approved these changes

@alxbilger alxbilger alxbilger approved these changes

Assignees

@epernod epernod

Labels
pr: fix Fix a bug pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. pr: status to review To notify reviewers to review this pull-request STC#17 Tasks for STC#17 coding sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a function in BaseMeshTopology to compute all topology containers
6 participants
@epernod @fredroy @alxbilger @damienmarchal @hugtalbot @bakpaul