Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaCore] Restore default component naming for python #2801

Merged
merged 1 commit into from
Mar 23, 2022
Merged

[SofaCore] Restore default component naming for python #2801

merged 1 commit into from
Mar 23, 2022

Conversation

EulalieCoevoet
Copy link
Contributor

Following my comment on #2773.
This PR restores the default component naming for python.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Mar 23, 2022
@damienmarchal damienmarchal added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Mar 23, 2022
@alxbilger alxbilger mentioned this pull request Mar 23, 2022
Merged
@alxbilger alxbilger merged commit 6a77f79 into sofa-framework:master Mar 23, 2022
fredroy pushed a commit to fredroy/sofa that referenced this pull request Mar 25, 2022
@EulalieCoevoet @fredroy
[SofaCore] restore default name for python (sofa-framework#2801)
a1d2a04
EulalieCoevoet added a commit to EulalieCoevoet/sofa that referenced this pull request Apr 20, 2022
@EulalieCoevoet
[SofaCore] restore default name for python (sofa-framework#2801)
c796774
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 11, 2022
@guparan guparan added this to the v22.06 milestone Jun 23, 2022
@guparan guparan added the pr: fix Fix a bug label Jun 23, 2022
@EulalieCoevoet EulalieCoevoet deleted the pr-pythonnaming branch July 27, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v22.06
Development

Successfully merging this pull request may close these issues.
5 participants
@EulalieCoevoet @guparan @alxbilger @damienmarchal @hugtalbot