[all] Fix warnings #376
Open
[all] Fix warnings #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
requested changes
Oct 9, 2023
| @@ -289,7 +289,7 @@ void PythonEnvironment::Init() | |||
| for( const auto& elem : map) | |||
| { | |||
| Plugin p = elem.second; | |||
| if ( p.getModuleName() == sofa_tostring(SOFA_TARGET) ) | |||
There was a problem hiding this comment.
What's the warning in this case?
| @@ -120,7 +120,7 @@ class SOFAPYTHON3_API PythonEnvironment | |||
| struct SceneLoaderListerner : public SceneLoader::Listener | |||
| { | |||
| /// possibly unload python modules to force importing their eventual modifications | |||
| virtual void rightBeforeLoadingScene(); | |||
| virtual void rightBeforeLoadingScene() override; | |||
There was a problem hiding this comment.
Suggested change
| virtual void rightBeforeLoadingScene() override; | |
| virtual void rightBeforeLoadingScene(SceneLoader* sceneLoader) override; |
There was a problem hiding this comment.
This also implies that sceneLoader is unused in the implementation of this function in the cpp file.
There was a problem hiding this comment.
This one was not just a warning. It is a bug introduced by sofa-framework/sofa#3799 because the override keyword was missing in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.