Change createdb.cpp so that it takes in ".txt" file containing paths of different fasta files #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/util/createdb.cpp
Outdated
| @@ -19,6 +19,28 @@ int createdb(int argc, const char **argv, const Command& command) { | |||
| std::vector<std::string> filenames(par.filenames); | |||
| std::string dataFile = filenames.back(); | |||
| filenames.pop_back(); | |||
| if (Util::endsWith(".txt", filenames[0])) { | |||
There was a problem hiding this comment.
Please use .tsv.
Also please adjust MMseqsBase.cpp to explain that users can pass in a tsv
There was a problem hiding this comment.
In the createdb module only, or in all search/cluster modules as well?
…usage to createdb and easy-search in MMseqsBase.cpp.
|
Now both your and Gyuri's PR contain partially this code and will result in a merge conflict when we try to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.