fix: do not execute code action commands twice [IDE-506][HEAD-229] #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
force-pushed
the
fix/IDE-506_HEAD-229_fix-code-action-behaviour
branch
from
b55138a
to
1d06ac7
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
deleted the
fix/IDE-506_HEAD-229_fix-code-action-behaviour
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eclipse and VSCode have slightly different behaviours. To cater for Eclipse's behaviour (HEAD-229) we added execution of commands during resolution of code actions. This is not correct and only worked, because we returned an empty code action afterwards to Eclipse which overwrote the command earlier contained.
In VSCode, the command of the code action is not overwritten by the resolved code action, thus
executeCommandwas called both in resolution and normal command execution.This implementation difference abides by protocol, but our returning changed fields after executing the command does not. The PR fixes this incorrect behaviour.
Checklist