handle inavalid receipt

backend/src/review/review.service.ts

@@ -24,11 +24,9 @@ export class ReviewService {
       restaurant: restaurantDto,
     } = createReviewDto;
 
-    console.log(createReviewDto);
-
     const restaurant =
       await this.restaurantRepository.findOrCreate(restaurantDto);
-    const images = await this.imageRepository.findBy({
+    let images = await this.imageRepository.findBy({
       id: In(imageIds.concat([receiptImageId ?? -1])),
     });
     const receiptImage = images.find((image) => image.id === receiptImageId);
@@ -37,11 +35,10 @@ export class ReviewService {
       await receiptImage.markAsReceipt();
       try {
         const receiptData = await getReceiptOcr(receiptImage.url);
-        console.log(receiptData);
         await receiptImage.markAsReceiptVerified();
         menu = receiptData['menu'];
       } catch (e) {
-        throw new BadRequestException('잘못된 영수증입니다.');
+        images = images.filter((image) => image.id !== receiptImageId);
       }
     }
 

backend/src/test/review/create-review.spec.ts

@@ -186,13 +186,13 @@ describe('Create Review test', () => {
       .expect(HttpStatus.BAD_REQUEST);
   });
 
-  it('영수증 에러나면 400', async () => {
+  it('영수증 에러나면 사진 빠진다', async () => {
     const image = await ImageFixture.create({});
 
     const receiptImageId = await ImageFixture.create({});
 
     jest.clearAllMocks();
-    (getReviewIsPositive as jest.Mock).mockRejectedValue(new Error('error'));
+    (getReceiptOcr as jest.Mock).mockRejectedValue(new Error('error'));
 
     await supertest(testServer.getHttpServer())
       .post('/reviews')
@@ -208,7 +208,24 @@ describe('Create Review test', () => {
         receiptImageId: receiptImageId.id,
       })
       .set('Authorization', `Bearer ${accessToken}`)
-      .expect(HttpStatus.BAD_REQUEST);
+      .expect(HttpStatus.CREATED);
+
+    const review = await ReviewEntity.findOneOrFail({
+      where: {
+        content: 'content',
+      },
+      relations: {
+        restaurant: true,
+        images: true,
+        user: true,
+      },
+    });
+
+    expect(review.images.length).toEqual(1);
+    expect(review.images[0].id).toEqual(image.id);
+    expect(review.images[0].isReceipt).toEqual(false);
+    expect(review.images[0].isReceiptVerified).toEqual(false);
+    expect(review.images[0].id).not.toEqual(receiptImageId.id);
   });
 
   it('레스토랑 없었으면 생성한다.', async () => {