-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Snowflake object name handling in the Snowpark AST #2789
base: main
Are you sure you want to change the base?
Conversation
The serialized batch was getting large enough to exceed command-line length limits
@@ -239,49 +206,39 @@ body { | |||
fn { | |||
builtin_fn { | |||
name { | |||
fn_name_flat { | |||
name: "col" | |||
name { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's nested twice -- is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the outer name
is of type SpNameRef
and comes from the trait FnNameRefExpr
, and the inner name
is the field of the SpNameRef
, of type SpName
.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1621205
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This is the client-side change corresponding to https://github.com/snowflakedb/snowflake/pull/240557
Unify Snowflake object name handling in the Snowpark AST.
Remove
FnName
andSpTableName
. They both hadFlat
andStructured
variants, but ultimately designate Snowflake object names.Introduce
data SpName
andentity SpNameRef
for referring to Snowflake objects by relative or fully qualified name.Update
FnNameRefExpr
.Use
SpNameRef
in a few places that used to useList[String]
.