Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for map datatype #541

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas commented Nov 13, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

  • Added support for the Snowflake MAP datatype, enabling users to work with Iceberg Tables that contain this type and reflect tables with the MAP datatype.
  • Updated table reflection to use the DESC TABLE statement instead of querying information_schema for a specific table, improving accuracy.
  • Column type reflection has been enhanced by parsing the full description of column types from the DESC TABLE statement, rather than relying on data from information_schema, ensuring more accurate type parsing.

Example:
MAP(TEXT(), TEXT(), not_null:True)

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas marked this pull request as ready for review November 16, 2024 00:53
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas requested a review from a team as a code owner November 16, 2024 00:53
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas merged commit 31d0da6 into main Nov 19, 2024
45 checks passed
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas deleted the add_suppopot_for_map_datatype branch November 19, 2024 16:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants