Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROD-235021 Reduced stress tests matrix #970

Merged
merged 2 commits into from
Oct 23, 2024
Merged

PROD-235021 Reduced stress tests matrix #970

merged 2 commits into from
Oct 23, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

Overview

PROD-135021

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner October 23, 2024 10:54
sfc-gh-achyzy
sfc-gh-achyzy approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-achyzy sfc-gh-achyzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-mbobowski sfc-gh-mbobowski enabled auto-merge (squash) October 23, 2024 11:15
@sfc-gh-mbobowski
Copy link
Contributor Author

Close / reopen - CI got stuck

@sfc-gh-mbobowski sfc-gh-mbobowski enabled auto-merge (squash) October 23, 2024 15:29
@sfc-gh-rdwivedi
Copy link

Thanks @sfc-gh-mbobowski - Lets merge this ASAP.

Btw how long will it take for this to be deployed and be effective?

@sfc-gh-mbobowski sfc-gh-mbobowski merged commit 020970f into master Oct 23, 2024
52 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-PROD-135021-stress-test branch October 23, 2024 17:01
@sfc-gh-mbobowski sfc-gh-mbobowski changed the title PROD-135021 Reduced stress tests matrix PROD-235021 Reduced stress tests matrix Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-dseweryn sfc-gh-dseweryn sfc-gh-dseweryn approved these changes

@sfc-gh-achyzy sfc-gh-achyzy sfc-gh-achyzy approved these changes

@sfc-gh-wtrefon sfc-gh-wtrefon sfc-gh-wtrefon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-mbobowski @sfc-gh-rdwivedi @sfc-gh-dseweryn @sfc-gh-achyzy @sfc-gh-wtrefon