Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1728000 Cloud platform tests filtering #968

Merged
merged 1 commit into from
Oct 24, 2024
Merged

SNOW-1728000 Cloud platform tests filtering #968

merged 1 commit into from
Oct 24, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Oct 22, 2024 •
edited
Loading

Overview

SNOW-1728000

This PR contains:

  • Adding cloud_platform flag to e2e test suites objects
  • Complete tests filtering (based on the user input, apache/confluent and cloud platform)
  • Some minor renaming from camel case to snake case (to be more Python-ish)
  • Code formatter (black with default settings) for test_suites.py and test_selector.py

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski force-pushed the mbobowski-SNOW--1728000-cloud-vendor-test-filtering-2 branch 3 times, most recently from 19bc224 to fe6ed2b Compare October 22, 2024 11:39
sfc-gh-mbobowski
sfc-gh-mbobowski commented Oct 22, 2024
View reviewed changes
test/test_suites.py
print("Running", len(testsToRun), "tests")
return testsToRun
"""
return OrderedDict(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only adding cloud_platform=CloudPlatform.ALL, to all suites and code formatter.

sfc-gh-mbobowski
sfc-gh-mbobowski commented Oct 22, 2024
View reviewed changes
test/test_selector.py
test_suites = create_end_to_end_test_suites(
driver, name_salt, schema_registry_address, test_platform
)
test_suites = self.__filter_by_allow_list(allowed_tests_csv, test_suites)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very skilled with Python so don't hesitate to suggest something more sophisticated here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could have here just one generic filtering function and pass a predicate lambda but i;m not python expert as well, ask copilot ;p

@sfc-gh-mbobowski sfc-gh-mbobowski force-pushed the mbobowski-SNOW--1728000-cloud-vendor-test-filtering-2 branch from fe6ed2b to 4fd964e Compare October 22, 2024 11:50
@sfc-gh-mbobowski sfc-gh-mbobowski marked this pull request as ready for review October 22, 2024 12:34
@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner October 22, 2024 12:34
@sfc-gh-mbobowski sfc-gh-mbobowski changed the title SNOW-1728000 Cloud platform tests filtering [DO NOT REVIEW YET] SNOW-1728000 Cloud platform tests filtering Oct 22, 2024
@sfc-gh-mbobowski sfc-gh-mbobowski force-pushed the mbobowski-SNOW--1728000-cloud-vendor-test-filtering-2 branch from 4fd964e to 6803e49 Compare October 22, 2024 12:53
@sfc-gh-mbobowski sfc-gh-mbobowski changed the title [DO NOT REVIEW YET] SNOW-1728000 Cloud platform tests filtering SNOW-1728000 Cloud platform tests filtering Oct 22, 2024
@sfc-gh-mbobowski sfc-gh-mbobowski merged commit 204e311 into master Oct 24, 2024
78 of 80 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-SNOW--1728000-cloud-vendor-test-filtering-2 branch October 24, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-wtrefon sfc-gh-wtrefon sfc-gh-wtrefon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mbobowski @sfc-gh-wtrefon