Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 2.0.2 Ingest SDK #675

Closed
wants to merge 12 commits into from
Closed

Update to 2.0.2 Ingest SDK #675

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
531bd9e
update to 2.0.2 sdk
sfc-gh-rcheng Jul 26, 2023
be34dc7
role requirement removed, remove sinkservicev2 test
sfc-gh-rcheng Jul 26, 2023
49ead76
autoformatting
sfc-gh-rcheng Jul 26, 2023
16fbff1
add for license
sfc-gh-rcheng Jul 26, 2023
fbf6955
remove for license
sfc-gh-rcheng Jul 26, 2023
3aba46d
fix license
sfc-gh-rcheng Jul 27, 2023
2860440
license
sfc-gh-rcheng Jul 27, 2023
25cf008
update jacksoncore
sfc-gh-rcheng Jul 27, 2023
01413b9
license
sfc-gh-rcheng Jul 27, 2023
54ee968
license again
sfc-gh-rcheng Jul 27, 2023
3e9302c
revitest
sfc-gh-rcheng Jul 27, 2023
118ce73
license issues
sfc-gh-rcheng Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@
<dependency>
<groupId>net.snowflake</groupId>
<artifactId>snowflake-ingest-sdk</artifactId>
<version>2.0.1</version>
<version>2.0.2</version>
<exclusions>
<exclusion>
<groupId>net.snowflake</groupId>
Expand Down
2 changes: 1 addition & 1 deletion pom_confluent.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@
<dependency>
<groupId>net.snowflake</groupId>
<artifactId>snowflake-ingest-sdk</artifactId>
<version>2.0.1</version>
<version>2.0.2</version>
<exclusions>
<exclusion>
<groupId>net.snowflake</groupId>
Expand Down
19 changes: 0 additions & 19 deletions src/test/java/com/snowflake/kafka/connector/internal/streaming/SnowflakeSinkServiceV2IT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import static com.snowflake.kafka.connector.internal.streaming.TopicPartitionChannel.NO_OFFSET_TOKEN_REGISTERED_IN_SNOWFLAKE;

import com.snowflake.kafka.connector.SnowflakeSinkConnectorConfig;
import com.snowflake.kafka.connector.Utils;
import com.snowflake.kafka.connector.dlq.InMemoryKafkaRecordErrorReporter;
import com.snowflake.kafka.connector.internal.SchematizationTestUtils;
import com.snowflake.kafka.connector.internal.SnowflakeConnectionService;
Expand All @@ -27,13 +26,11 @@
import java.util.List;
import java.util.Map;
import net.snowflake.client.jdbc.internal.fasterxml.jackson.databind.ObjectMapper;
import net.snowflake.ingest.utils.SFException;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.connect.data.Schema;
import org.apache.kafka.connect.data.SchemaAndValue;
import org.apache.kafka.connect.data.SchemaBuilder;
import org.apache.kafka.connect.data.Struct;
import org.apache.kafka.connect.errors.ConnectException;
import org.apache.kafka.connect.json.JsonConverter;
import org.apache.kafka.connect.sink.SinkRecord;
import org.junit.After;
Expand Down Expand Up @@ -764,22 +761,6 @@ public void testBrokenRecordIngestionAfterValidRecord() throws Exception {
service.closeAll();
}

@Test(expected = ConnectException.class)
public void testMissingPropertiesForStreamingClient() {
Map<String, String> config = TestUtils.getConfForStreaming();
config.remove(Utils.SF_ROLE);
SnowflakeSinkConnectorConfig.setDefaultValues(config);

try {
SnowflakeSinkServiceFactory.builder(conn, IngestionMethodConfig.SNOWPIPE_STREAMING, config)
.build();
} catch (ConnectException ex) {
assert ex.getCause() instanceof SFException;
assert ex.getCause().getMessage().contains("Missing role");
throw ex;
}
}

/* Service start -> Insert -> Close. service start -> fetch the offsetToken, compare and ingest check data */

@Test
Expand Down
Loading