-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1757822: Allow JDBC to handle ZSTD decompression #1932
base: master
Are you sure you want to change the base?
Conversation
src/test/java/net/snowflake/client/jdbc/DefaultResultStreamProviderTest.java
Outdated
Show resolved
Hide resolved
} | ||
|
||
@Test | ||
public void testDetectContentEncodingAndGetInputStream_Zstd() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with such approach is that if we compress and decompress using the same tool, which contains some bug, we will silently pass a test. But there is probably no better approach now unless we use a fixed file which is compressed somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly we could use some system utility like command line zstd
in a subprocess to have this 3rd party library for verification? We'd need to ensure it's available on test environments though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now we should wait for full backend support of ZSTD chunks compression and then properly test the integration, because the most important thing is whether we are able to decompress what backend compresses. 3rd party tools are of smaller importance here IMO
…edb/snowflake-jdbc into SNOW-1757822-zstd-decompression
Overview
SNOW-1757822
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.