Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1708304: Download stream from git repository #1920

Merged
merged 1 commit into from
Oct 22, 2024
Merged

SNOW-1708304: Download stream from git repository #1920

merged 1 commit into from
Oct 22, 2024

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Overview

SNOW-1708304

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner October 15, 2024 10:25
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1708304-download-stream-from-git-repository branch 2 times, most recently from 0ecc6ea to 2bdf3fd Compare October 15, 2024 11:01
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1708304-download-stream-from-git-repository branch 5 times, most recently from 1e60bf1 to 6350d27 Compare October 21, 2024 05:42
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1708304-download-stream-from-git-repository branch from 6350d27 to 6f4195c Compare October 21, 2024 11:37
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1708304-download-stream-from-git-repository branch from 6f4195c to 77b10cb Compare October 22, 2024 07:15
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit ea6abe1 into master Oct 22, 2024
142 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1708304-download-stream-from-git-repository branch October 22, 2024 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-krzymkowski sfc-gh-krzymkowski sfc-gh-krzymkowski left review comments

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-astachowski sfc-gh-astachowski sfc-gh-astachowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-dprzybysz @sfc-gh-krzymkowski @sfc-gh-pbulawa @sfc-gh-pmotacki @sfc-gh-astachowski