Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-618478: Support private key base64 in connection parameters #1847

Merged
merged 12 commits into from
Aug 28, 2024
Merged

SNOW-618478: Support private key base64 in connection parameters #1847

merged 12 commits into from
Aug 28, 2024

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Overview

SNOW-618478

Based on #1810

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner July 30, 2024 12:55
@josecsotomorales
Copy link

Thanks for taking this @sfc-gh-dprzybysz! It helps a lot of Hikari <> Snowflake users 🚀

@ets
Copy link
Contributor

ets commented Aug 10, 2024

@sfc-gh-dstempniak @sfc-gh-dprzybysz I made improvements based upon your feedback to the fork on https://github.com/Qualytics/snowflake-jdbc/tree/master which formed the original PR. It's rebased against your master branch.

sfc-gh-dheyman-1 and others added 3 commits August 14, 2024 11:58
@sfc-gh-dheyman-1 @sfc-gh-mkubik
SNOW-1618131: Remove error_on_generic_pruner integration test (#1866)
f01dcc5
@sfc-gh-wfateem @sfc-gh-mkubik
SNOW-1614292: java.lang.ClassNotFoundException: org.slf4j.LoggerFactor (
4060fe1 
#1862)

Fixes issue where the absence of the slf4j-api library from the classpath
results in a NoClassDefFoundError/ClassNotFoundException because
the class org.slf4j.LoggerFactory can't be found
@sfc-gh-mkubik
SNOW-618478: Introduce unified property for private key file and base…
f22fce4 
…64 bytes

Adds private_key_pwd session property that may be used interchangeably with existing private_key_file_pwd. Marks private_key_file_pwd property as deprecated as in the future it'll be completely replaced with private_key_pwd. Rename usages of privateKeyFilePwd to privateKeyPwd to clarify that from now it may refer not only to the file but also private_key_base64.
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-mkubik
SNOW-618478: Introduce unified property for private key file and base…
ea2c44a 
…64 bytes

Adds private_key_pwd session property that may be used interchangeably with existing private_key_file_pwd. Marks private_key_file_pwd property as deprecated as in the future it'll be completely replaced with private_key_pwd. Rename usages of privateKeyFilePwd to privateKeyPwd to clarify that from now it may refer not only to the file but also private_key_base64.
@josecsotomorales
Copy link

Do we have a timeline of when this PR will get merged?

@sfc-gh-mkubik
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-mkubik
Copy link
Contributor

@sfc-gh-dstempniak @sfc-gh-dprzybysz I made improvements based upon your feedback to the fork on https://github.com/Qualytics/snowflake-jdbc/tree/master which formed the original PR. It's rebased against your master branch.

@ets Thank you for your contribution. There was already some divergence between this PR and the fork so I looked through your changes and migrated them to this branch. I believe this approach should work for you.

@sfc-gh-mkubik
Copy link
Contributor

Do we have a timeline of when this PR will get merged?

Sorry @josecsotomorales I missed your comment, I'm still working on some failing checks but we're aiming to get this PR merged before the August release.

sfc-gh-mkubik and others added 3 commits August 28, 2024 11:18
@sfc-gh-mkubik
resolve conflicts in SFSession
ccfd2dc
@sfc-gh-mkubik
Merge branch 'SNOW-618478-support-private-key-base64-in-connection-pa…
7f97609 
…rameters' of github.com:snowflakedb/snowflake-jdbc into SNOW-618478-support-private-key-base64-in-connection-parameters
@sfc-gh-pbulawa
SNOW-144173: Add more cases (#1764)
464b199
@sfc-gh-mkubik sfc-gh-mkubik enabled auto-merge (squash) August 28, 2024 14:36
@sfc-gh-mkubik sfc-gh-mkubik merged commit 41582e8 into master Aug 28, 2024
140 of 142 checks passed
@sfc-gh-mkubik sfc-gh-mkubik deleted the SNOW-618478-support-private-key-base64-in-connection-parameters branch August 28, 2024 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ets ets ets left review comments

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak left review comments

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sfc-gh-dprzybysz @josecsotomorales @ets @sfc-gh-mkubik @sfc-gh-pbulawa @sfc-gh-dstempniak @sfc-gh-dheyman-1 @sfc-gh-wfateem