SNOW-852665: Allow ~ in PUT/GET file path #1481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-852665
PUT commands will fail if the source file path contains ~ even though this is accepted in folder names. This is because during parsing of the command, the driver filters out any ~ with the user home directory.
So file path in the command
"PUT 'file:///C:/snowflake~/test.txt' '@~' AUTO_COMPRESS=FALSE"
would be parsed to "/C:/snowflakeC:\Users\user/test.txt
"GET commands will also fail if trying to download to a directory with ~ in the path name. This is because the driver checks if ~ is at the start of the command, then replaces with the user home directory. Afterwards it checks to see if the command still contains an ~ and will throw a PATH_NOT_DIRECTORY error.
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes PUT command fails with ~ in file name #1458
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/508
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Ensure that ~ is only replaced for PUT/GET if it's at the start of the command. Otherwise, allow ~ in folder directories.
Pre-review checklist