close httpClient when closing simpleIngestManager #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we okay doing this way (cloning the PR and opening again), should we need CLA signed from author? @sfc-gh-xhuang |
|
@sfc-gh-japatel Confluent has a CLA already |
|
This is Snowpipe, we will need Snowpipe folks to review the change |
|
@sfc-gh-tzhang I've asked Snowpipe team to take a look for approval but it seems the failing test is a streaming test? |
Yes, the failure can be ignored, I have asked Alec to take a look since his PR has the same failure, does look like a real issue |
|
Team, any updates on this. Can we have this as part of 2.1.x release as well ? |
sfc-gh-yawang
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging pr from @nirutgupta
#930
The CloseableHttpResponse is closed with try catch (ref), but the client itself is not getting closed, in case if exception is thrown here. This is causing connection leaks, timeout errors and decrease in throughput.
Added the fix to close the httpClient in SimpleIngestManager close() method.
Will add ingestManager.close() here post this change.