[SNOW-559751] Add role switching to SimpleIngestManager #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tzhang
approved these changes
Apr 12, 2022
| * @param hostName the hostname | ||
| * @param keyPair keyPair associated with the private key used for authentication. See @see {@link | ||
| * Utils#createKeyPairFromPrivateKey} to generate KP from p8Key | ||
| * @param userAgentSuffix user agent suffix we want to add. |
There was a problem hiding this comment.
please add comment for role
| @@ -388,6 +440,28 @@ public SimpleIngestManager( | |||
| new RequestBuilder(account, user, keyPair, schemeName, hostName, port, userAgentSuffix); | |||
| } | |||
|
|
|||
| /* Another flavor of constructor which supports userAgentSuffix and role */ | |||
| * RequestBuilder constructor which uses default schemes, host and port. | ||
| * | ||
| * @param accountName - the name of the Snowflake account to which we're connecting | ||
| * @param userName - the username of the entity loading files |
| assertEquals(0L, configureClientResponse.getClientSequencer().longValue()); | ||
| } | ||
|
|
||
| @Ignore |
There was a problem hiding this comment.
why these tests are ignored for now? Could you add a JIRA for enabling them?
There was a problem hiding this comment.
These tests are disabled from the beginning as they arose. I don't know what the story is behind this.
https://github.com/snowflakedb/snowflake-ingest-java/pull/105/files
There was a problem hiding this comment.
@sfc-gh-japatel i think it could be enabled now?
There was a problem hiding this comment.
I have it enabled already but I forgot to push.
sfc-gh-kbregula
changed the title
sfc-gh-kbregula
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Depends on: https://github.com/snowflakedb/snowflake/pull/52893
Doc: https://docs.google.com/document/d/1gSeQeGdJGxXRbRp1QiuEzeCjiQdqLnUdcCp7IhyV2LU/edit#
Best regards,
Kamil Breguła