Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gcp test so that gcs downscoped is always enabled #2012

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Fix gcp test so that gcs downscoped is always enabled #2012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd248e9
presigned url depracated, always enable downcoped
sfc-gh-yuwang Aug 1, 2024
bd5aee7
fix test
sfc-gh-yuwang Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/integ/test_put_get_with_gcp_account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
pytestmark = pytest.mark.gcp


@pytest.mark.parametrize("enable_gcs_downscoped", [True, False])
@pytest.mark.parametrize("enable_gcs_downscoped", [True])
@pytest.mark.parametrize(
"from_path", [True, pytest.param(False, marks=pytest.mark.skipolddriver)]
)
Expand Down Expand Up @@ -127,7 +127,7 @@ def test_put_get_with_gcp(
assert original_contents == contents, "Output is different from the original file"


@pytest.mark.parametrize("enable_gcs_downscoped", [True, False])
@pytest.mark.parametrize("enable_gcs_downscoped", [True])
def test_put_copy_many_files_gcp(
tmpdir,
conn_cnx,
Expand Down Expand Up @@ -192,7 +192,7 @@ def run(csr, sql):
run(csr, "drop table if exists {name}")


@pytest.mark.parametrize("enable_gcs_downscoped", [True, False])
@pytest.mark.parametrize("enable_gcs_downscoped", [True])
def test_put_copy_duplicated_files_gcp(
tmpdir,
conn_cnx,
Expand Down Expand Up @@ -288,7 +288,7 @@ def run(csr, sql):
run(csr, "drop table if exists {name}")


@pytest.mark.parametrize("enable_gcs_downscoped", [True, False])
@pytest.mark.parametrize("enable_gcs_downscoped", [True])
def test_put_get_large_files_gcp(
tmpdir,
conn_cnx,
Expand Down Expand Up @@ -476,7 +476,7 @@ def mocked_get(*args, **kwargs):
assert original_contents == contents, "Output is different from the original file"


@pytest.mark.parametrize("enable_gcs_downscoped", [True, False])
@pytest.mark.parametrize("enable_gcs_downscoped", [True])
def test_auto_compress_off_gcp(
tmpdir,
conn_cnx,
Expand Down
Loading