Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1516350: disable oob telemetry #1991

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Jul 3, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1516350

disable oob in the python connector, remove oob tests

we keep the implementation there as the implementation is still needed by the snowpark python local testing framework: snowflakedb/snowpark-python#1878.

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  3. (Optional) PR for stored-proc connector:

@sfc-gh-aling sfc-gh-aling force-pushed the SNOW-1518381-disabling-general-oob-telemetry-in-python-driver-while-exposing-the-capability-to-local-testing branch from d1db85a to a2ace61 Compare July 10, 2024 21:58
@sfc-gh-aling sfc-gh-aling changed the title force disabling oob telemetry SNOW-1516350: disable oob telemetry Jul 10, 2024
@sfc-gh-aling sfc-gh-aling added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 10, 2024
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review July 10, 2024 22:00
@sfc-gh-aling sfc-gh-aling force-pushed the SNOW-1518381-disabling-general-oob-telemetry-in-python-driver-while-exposing-the-capability-to-local-testing branch from b83a6c3 to e910b81 Compare July 11, 2024 00:17
@sfc-gh-aling sfc-gh-aling added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Jul 11, 2024
@sfc-gh-aling sfc-gh-aling merged commit 0d00519 into main Jul 12, 2024
93 of 95 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1518381-disabling-general-oob-telemetry-in-python-driver-while-exposing-the-capability-to-local-testing branch July 12, 2024 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants