Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1055240: Add tests for iceberg table structured types metadata #1903

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SNOW-1055240: Add tests for iceberg table structured types metadata #1903

wants to merge 1 commit into from
+78 −1

Conversation

sfc-gh-yixie
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1055240

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yixie sfc-gh-yixie added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Mar 19, 2024
sfc-gh-jrose
sfc-gh-jrose reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You probably want to skip if iceberg not supported, otherwise these tests will fail in some suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose left review comments

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-yixie @sfc-gh-jrose