Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1739583 Fix of rounding issue #1045

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

Description

Fix of rounding issue, to avoid the situation with backOffInSec == 0:

 2024-10-24 12:57:16,009 [35] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 1 sec.
 2024-10-24 12:57:17,020 [36] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 1 sec.
 2024-10-24 12:57:18,036 [36] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 3 sec.
 2024-10-24 12:57:21,403 [41] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 0 sec.
 2024-10-24 12:57:21,403 [41] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 0 sec.
 2024-10-24 12:57:21,403 [41] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 0 sec.
 2024-10-24 12:57:21,403 [41] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 0 sec.
 2024-10-24 12:57:21,403 [41] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 0 sec.
 2024-10-24 12:57:21,403 [41] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 0 sec.
 2024-10-24 12:57:21,403 [41] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 0 sec.
 2024-10-24 12:57:21,403 [41] [WARN ] [Snowflake.Data.Log.Log4NetImpllassName:61] - Http request timeout. Retry the request after 0 sec.
...

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.01%. Comparing base (898a2f0) to head (8be966b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage   86.07%   86.01%   -0.07%     
==========================================
  Files         118      118              
  Lines       11512    11512              
  Branches     1157     1157              
==========================================
- Hits         9909     9902       -7     
- Misses       1324     1328       +4     
- Partials      279      282       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dstempniak sfc-gh-dstempniak marked this pull request as ready for review October 24, 2024 14:15
@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner October 24, 2024 14:15
@sfc-gh-dstempniak sfc-gh-dstempniak merged commit f995ba6 into master Oct 25, 2024
51 of 52 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-1739583_2 branch October 25, 2024 09:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants