Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1747456] Remove side effects from command registration #1945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SNOW-1747456] Remove side effects from command registration #1945

wants to merge 1 commit into from

Conversation

sfc-gh-pjob
Copy link
Contributor

@sfc-gh-pjob sfc-gh-pjob commented Dec 11, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

  • Introduced app factory

@sfc-gh-pjob sfc-gh-pjob force-pushed the pjob/SNOW-1747456-remove-side-effects-from-command-registration branch from 07dbd92 to daa3281 Compare December 19, 2024 17:56
@sfc-gh-pjob sfc-gh-pjob marked this pull request as ready for review December 19, 2024 17:56
@sfc-gh-pjob sfc-gh-pjob requested review from a team as code owners December 19, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-pjob