-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize names used in the artifact processor pipeline #1933
Open
sfc-gh-bdufour
wants to merge
9
commits into
features/unification-artifacts
Choose a base branch
from
bdufour-artifacts-generalize-names
base: features/unification-artifacts
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Generalize names used in the artifact processor pipeline #1933
sfc-gh-bdufour
wants to merge
9
commits into
features/unification-artifacts
from
bdufour-artifacts-generalize-names
+5,954
−2,681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bdufour
commented
Dec 6, 2024
Comment on lines
+25
to
26
class ArtifactProcessorContext: | ||
package_name: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: this will be refactored next
* Added glob support for Snowpark and Streamlit * Added glob support for Snowpark and Streamlit * Added glob support for Snowpark and Streamlit * Changed PathMapping.src to Path * Changes after review * Changes after review 2 * Revert "Changed PathMapping.src to Path" This reverts commit 3eb543d. * Changes after review 3 * Changes after review 4 * Added full global support * Renamed feature flag and added release notes * Removed or None
Fix feature branch gates
sfc-gh-bdufour
force-pushed
the
bdufour-artifacts-generalize-names
branch
from
December 9, 2024 22:53
4753ff4
to
17e4b2a
Compare
sfc-gh-bdufour
changed the base branch from
bdufour/unification-artifacts
to
features/unification-artifacts
December 9, 2024 22:54
sfc-gh-bdufour
changed the base branch from
features/unification-artifacts
to
main
December 9, 2024 23:16
sfc-gh-bdufour
changed the base branch from
main
to
features/unification-artifacts
December 9, 2024 23:17
sfc-gh-bdufour
changed the base branch from
features/unification-artifacts
to
main
December 9, 2024 23:17
sfc-gh-bdufour
changed the base branch from
main
to
features/unification-artifacts
December 9, 2024 23:21
sfc-gh-melnacouzi
approved these changes
Dec 11, 2024
sfc-gh-astus
force-pushed
the
features/unification-artifacts
branch
2 times, most recently
from
December 13, 2024 10:07
2bee685
to
c15cca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Refactoring names using the processor pipeline to be more general. This is in preparation for moving processor logic to a common module (and out of native apps)
Verified through
grep
that all occurrences of the terms being changes here have been replaced.