Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/unification artifacts #1920

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Features/unification artifacts #1920

wants to merge 10 commits into from

Conversation

sfc-gh-astus
Copy link
Contributor

@sfc-gh-astus sfc-gh-astus commented Dec 4, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

  • Added support for glob pattern in artifact paths in snowflake.yml for Streamlit.
  • Added support for glob pattern in artifact paths in snowflake.yml for Snowpark, requires ENABLE_SNOWPARK_GLOB_SUPPORT feature flag.
  • Extracted artifacts common logic to common package.

@sfc-gh-astus sfc-gh-astus requested review from a team as code owners December 4, 2024 17:04
@sfc-gh-bdufour sfc-gh-bdufour force-pushed the features/unification-artifacts branch 2 times, most recently from 85d1c72 to 9cb87b3 Compare December 9, 2024 21:15
@sfc-gh-astus
Copy link
Contributor Author

Check if --project in streamlit works on this branch.

@sfc-gh-astus sfc-gh-astus force-pushed the features/unification-artifacts branch from bf62cfb to 7cd92a3 Compare December 12, 2024 17:53
@sfc-gh-astus sfc-gh-astus changed the title [DO NOT MERGE] Features/unification artifacts Features/unification artifacts Dec 12, 2024
sfc-gh-astus and others added 10 commits December 13, 2024 09:13
@sfc-gh-astus
Added glob support for snowpark and streamlit (#1862)
ebb56f8 
* Added glob support for Snowpark and Streamlit

* Added glob support for Snowpark and Streamlit

* Added glob support for Snowpark and Streamlit

* Changed PathMapping.src to Path

* Changes after review

* Changes after review 2

* Revert "Changed PathMapping.src to Path"

This reverts commit 3eb543d.

* Changes after review 3

* Changes after review 4

* Added full global support

* Renamed feature flag and added release notes

* Removed or None
@sfc-gh-bdufour @sfc-gh-astus
Fix broken v1 to v2 test on the feature branch (#1876)
986d198
@sfc-gh-bdufour @sfc-gh-astus
Moved native app artifacts logic to common API (#1877)
01e062a
@sfc-gh-bdufour @sfc-gh-astus
Move PathMapping and ProcessorMapping out of native app logic (#1899)
caf9f1b
@sfc-gh-bdufour @sfc-gh-astus
Fix rebase issues in feature/unification-artifacts (#1932)
1fe4e7c 
Fix feature branch gates
@sfc-gh-bdufour @sfc-gh-astus
Fixes to imports following rebase
40354fb
@sfc-gh-astus
Moved Snowpark and Streamlit artifacts to separate directory in outpu… (
bf1a0e2 
#1909)

Moved Snowpark and Streamlit artifacts to separate directory in output/deploy
@sfc-gh-astus
Updated release-notes
e14a06c
@sfc-gh-astus
Fixed import after rebase
385b3af
@sfc-gh-astus
Fixes after rebase
c15cca5
@sfc-gh-astus sfc-gh-astus force-pushed the features/unification-artifacts branch from 2bee685 to c15cca5 Compare December 13, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-astus @sfc-gh-bdufour