Add optional subdirectory for stage in application package #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…kedb/snowflake-cli into pj-subartifacts-subdirs
sfc-gh-pjafari
changed the title
sfc-gh-pjafari
commented
Dec 5, 2024
sfc-gh-pjafari
commented
Dec 5, 2024
src/snowflake/cli/_plugins/nativeapp/codegen/templates/templates_processor.py
Outdated
Show resolved
Hide resolved
sfc-gh-pjafari
changed the base branch from
main
to
pj-template-processor-error
sfc-gh-pjafari
changed the base branch from
pj-template-processor-error
to
main
src/snowflake/cli/_plugins/nativeapp/entities/application_package.py
Outdated
Show resolved
Hide resolved
src/snowflake/cli/_plugins/nativeapp/entities/application_package.py
Outdated
Show resolved
Hide resolved
src/snowflake/cli/_plugins/nativeapp/entities/application_package.py
Outdated
Show resolved
Hide resolved
| return ( | ||
| self.project_root | ||
| / self._entity_model.deploy_root | ||
| / self._entity_model.stage_subdirectory |
There was a problem hiding this comment.
why is this changing? Seems like an unnecessary complication
There was a problem hiding this comment.
The deploy_root is now deploy_root/subdir. So all the actions (bundle, deploy, etc) that need to refer to deploy root to write/read artifacts look at this subdir.
I don't think I understand what you mean by unnecessary complication.
There was a problem hiding this comment.
I mean why is the deploy root now deploy_root/subdir?
src/snowflake/cli/_plugins/nativeapp/entities/application_package.py
Outdated
Show resolved
Hide resolved
tests_integration/test_data/projects/napp_stage_subdirs/snowflake.yml
Outdated
Show resolved
Hide resolved
tests_integration/test_data/projects/napp_stage_subdirs/snowflake.yml
Outdated
Show resolved
Hide resolved
sfc-gh-pjafari
force-pushed
the
pj-subartifacts-subdirs
branch
from
8347118 to
b94bad5
Compare
sfc-gh-melnacouzi
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Added an optional
stage_subdirectoryto the application package.This change means that the root of the stage is no longer the assumed path to finding the artifacts and the
manifest.yml. If specified, the application package will only ever operate onstage/stage_subdirectory. This includesdeploy,diff, andversion create.For detailed information on how this affects each command, if specified, refer to the design document.