NA+SPCS setup script modifications PoC #1827
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fcampbell
force-pushed
the
frank-spcs-poc
branch
2 times, most recently
from
655992c to
d65286a
Compare
Comment on lines
603
to
716
| return dedent( | ||
| f"""\ | ||
| -- Begin generated SPCS services, this section is managed by the Snowflake CLI | ||
| create schema if not exists _spcs_generation; | ||
|
|
||
| create or replace procedure {name}(privileges array) | ||
| returns string | ||
| as $$ | ||
| begin | ||
| {f'call {existing_grant_callback}(privileges);' if existing_grant_callback else ''} | ||
| if (array_contains('CREATE COMPUTE POOL'::variant, privileges)) then | ||
| create compute pool if not exists {service.compute_pool} | ||
| min_nodes = {service.min_nodes} | ||
| max_nodes = {service.max_nodes} | ||
| instance_family = {service.instance_family}; | ||
| end if; | ||
| if (array_contains('BIND SERVICE ENDPOINT'::variant, privileges)) then | ||
| create service if not exists _spcs_generation.{service.fqn.name} | ||
| in compute pool {service.compute_pool} | ||
| from specification_file = '{service.specification_file}'; | ||
| end if; | ||
| return 'done'; | ||
| end; | ||
| $$; | ||
|
|
||
| create application role if not exists _spcs_generation_role; | ||
| grant usage on procedure {name}(array) to application role _spcs_generation_role; | ||
|
|
||
| -- End generated SPCS services | ||
| """ |
There was a problem hiding this comment.
Do you see a way to reuse the same logic from SpcsEntity.deploy() or ServiceEntity.deploy() once it will be implemented?
| return bundle_map | ||
|
|
||
| def _inject_spcs(self, spcs_services: list[ServiceEntity]): |
There was a problem hiding this comment.
Looks okay as a PoC, but we probably need to be more careful when we auto-modify the manifest and setup script
Comment on lines
+120
to
+123
| services: list[str] = Field( | ||
| title="List of Snowpark Container Service entity IDs to integrate into this application package", | ||
| default=[], | ||
| ) |
There was a problem hiding this comment.
Not sure there's a real problem here, but by omitting the proposed children field we lose the ability to order these internal dependencies
sfc-gh-fcampbell
force-pushed
the
frank-spcs-poc
branch
from
d65286a to
2f3309e
Compare
sfc-gh-fcampbell
force-pushed
the
frank-spcs-poc
branch
from
2f3309e to
01440bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
snow app runsnow app open