refactor post deploy hooks to use sql facade and clean up tests with factories #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mchok
commented
Oct 25, 2024
Comment on lines
+645
to
+646
| if run_post_deploy_hooks: | ||
| self.execute_post_deploy_hooks() |
There was a problem hiding this comment.
Since this will be calling use_role through the sql facade, we don't need to nest it inside the above context manager
sfc-gh-mchok
commented
Oct 25, 2024
| @mock.patch(MOCK_CONNECTION_DB, new_callable=mock.PropertyMock) | ||
| @mock.patch(MOCK_CONNECTION_WH, new_callable=mock.PropertyMock) | ||
| @mock.patch.dict(os.environ, {"USER": "test_user"}) | ||
| def test_sql_scripts_with_no_warehouse_no_database( |
There was a problem hiding this comment.
I decided to pass the role/warehouse to the sql facade in execute_post_deploy_hooks so that it wasn't dependent on previous calls to use_role/warehouse by the executor, which makes this test invalid with the new setup
Comment on lines
+567
to
+570
| app_role = (model.meta and model.meta.role) or workspace_ctx.default_role | ||
| app_warehouse = ( | ||
| model.meta and model.meta.warehouse | ||
| ) or workspace_ctx.default_warehouse |
There was a problem hiding this comment.
you should rebase on top of Frank's latest work (expect conflicts though, but it will make your job easier overall)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description